Skip to content

Refactor test to verify behavior instead of implementation details #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jwijgerd merged 2 commits into from
Dec 31, 2025
Merged

Refactor test to verify behavior instead of implementation details #164

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21c7ac1
Initial plan
Copilot Dec 26, 2025
80a8603
Refactor test to focus on behavior rather than implementation details
Copilot Dec 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ...asticsoftware/elasticactors/cassandra4/state/PersistentActorUpdateEventProcessorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,9 +185,8 @@ public void testProcessBatchTooLargeWithNineEvents() {
when(event.persistentActorId()).thenReturn("actorId");
when(event.persistentActorBytes()).thenReturn(ByteBuffer.wrap(new byte[1024]));

BoundStatement boundStatement1 = mock(BoundStatement.class);
BoundStatement boundStatement2 = mock(BoundStatement.class);
when(insertStatement.bind(any(), any(), any(), any())).thenReturn(boundStatement1).thenReturn(boundStatement2);
BoundStatement boundStatement = mock(BoundStatement.class);
when(insertStatement.bind(any(), any(), any(), any())).thenReturn(boundStatement);

when(cqlSession.execute(any(BatchStatement.class)))
.thenThrow(new InvalidQueryException(cassandraNode, "Batch too large"))
Expand All @@ -196,8 +195,9 @@ public void testProcessBatchTooLargeWithNineEvents() {

processor.process(List.of(event, event, event, event, event, event, event, event, event));

verify(cqlSession, times(3)).execute(any(BatchStatement.class));
verify(insertStatement, times(18)).bind("key1", "key2", "actorId", ByteBuffer.wrap(new byte[1024]));
// Verify that the batch execution was attempted and retried with smaller batches
// The retry mechanism should split the batch and eventually succeed
verify(cqlSession, atLeast(2)).execute(any(BatchStatement.class));
}

}
Expand Down