[Feature] Added improved automatic closing of the notification on charging state change#33
Open
Nikl174 wants to merge 6 commits intoelectrickite:masterfrom
Open
[Feature] Added improved automatic closing of the notification on charging state change#33Nikl174 wants to merge 6 commits intoelectrickite:masterfrom
Nikl174 wants to merge 6 commits intoelectrickite:masterfrom
Conversation
change recognition using inotify
unecessary signal handling
Author
|
It is also possible to implement it without starting any threads(using poll with a timeout on the watching fd), but then i need to detect, which battery is in use and I"m not sure, if this then reliably closes the notification when 2 (or more) batteries are in use and then switched by the firmware.... |
Author
|
Should work now stable, in the log-messages I saw that may events occurred on state-file-change which results in many recalculations in the batsignal cycle. I could add delay decrease the number of events, but its not necessary though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
To improve the performance of closing the notification without decreasing the performance of batsignal (increasing the polling rate) I implemented a file watcher (for all batteries detected) via the kernel API inotify and conditional variables for signaling.
How does it work
Here a summary of what happens:
(same on timeout of the wait for the conditional variable)
Whats left to do