tools: preserve GEX44 box-only tooling before decommission - #1692
Conversation
…-finisher lane, unity save/launch ops, gbuffer derivation, display config)
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 41 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (19)
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Comment |
evaOS review status: closed or merged before reviewPR: #1692 - tools: preserve GEX44 box-only tooling before decommission evaOS review stopped because the PR closed or merged before this queued head could be reviewed. Automation note: agents should wait for this comment to reach PR URL: #1692 |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 12927ca6f3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,41 @@ | |||
| # GEX44 box — preserved tooling & reproducible setup | |||
|
|
|||
| The GEX44 GPU box (`root@46.4.26.123`, RTX 4000 Ada / 64GB) was WorldOS's primary Unity render | |||
There was a problem hiding this comment.
Remove the operator endpoint from tracked documentation
Tracking the exact root@46.4.26.123 SSH endpoint exposes operator-only connection information and makes it persist even after older operational documentation is cleaned up or the address is reassigned. Keep only the non-sensitive host identifier here and leave connection details in the designated external secrets/configuration.
AGENTS.md reference: AGENTS.md:L35-L35
Useful? React with 👍 / 👎.
| LOG=/home/unity/worldos-autosave.log | ||
| ts() { date -u +%FT%TZ; } | ||
| # Don't capture a mid-write tree: if any source file changed in the last 90s, Unity may be writing. | ||
| if find Assets Packages ProjectSettings -type f -newermt '-90 seconds' 2>/dev/null | head -1 | grep -q .; then |
There was a problem hiding this comment.
Make the quiescence probe survive pipefail
When Unity has recently touched enough files to fill the pipe buffer, head -1 closes its input and find exits with SIGPIPE; because pipefail is enabled, the whole pipeline becomes false even though matches exist. This is reproducible with a large set of recent files and causes the script to proceed into git add precisely during a multi-file Unity write, potentially committing an inconsistent checkpoint; use a terminating find expression such as -print -quit instead of this pipeline.
Useful? React with 👍 / 👎.
| echo "$(ts) clean: nothing to save" >>"$LOG"; exit 0 | ||
| fi | ||
| git add -A | ||
| git commit -q -m "autosave $(ts): working-tree checkpoint" && echo "$(ts) committed locally" >>"$LOG" |
There was a problem hiding this comment.
Stop when the autosave commit fails
If git commit fails—for example because of an index lock, missing identity, hook failure, or LFS filter error—the && only suppresses the success message and execution continues. A non-push run can consequently exit successfully with the tree still dirty, while a --push run can push the old main ref and log that GitHub was updated, silently defeating this script's primary persistence contract; explicitly log and exit nonzero on commit failure.
Useful? React with 👍 / 👎.
| # GEX44 box — preserved tooling & reproducible setup | ||
|
|
||
| The GEX44 GPU box (`root@46.4.26.123`, RTX 4000 Ada / 64GB) was WorldOS's primary Unity render | ||
| host + image-detail lane. It is being decommissioned. This directory versions the box-only tooling |
There was a problem hiding this comment.
Reconcile the decommission notice with canonical host routing
Declaring this host to be under decommission conflicts with the canonical bootstrap and WorldOS-GUI-RUNBOOK.md, which still route heavy sweeps and Unity rendering to GEX44 as the preferred host. After decommissioning, agents following those entry points will continue scheduling work against a retired machine; update the canonical routing and fallback instructions atomically with this notice, or defer the decommission wording until that transition occurs.
AGENTS.md reference: AGENTS.md:L36-L36
Useful? React with 👍 / 👎.
| @@ -0,0 +1,139 @@ | |||
| # WorldOSPlayer — install & run | |||
There was a problem hiding this comment.
Replace the player notes with box setup instructions
A restoration operator is directed to this file for box bring-up, but it consists of old macOS WorldOSPlayer release notes and launch directions and contains no installation, file-placement, service, cron, dependency, or configuration steps for the tooling preserved here. This prevents the directory from serving its stated reproducibility purpose; replace the file with the actual host setup procedure or point it to the canonical GPU-VM recipe.
AGENTS.md reference: AGENTS.md:L36-L36
Useful? React with 👍 / 👎.
| head += "\r\n\r\n" | ||
| parts.append(head.encode() + (value if is_file else value.encode()) + b"\r\n") | ||
| add("image", content, filename=fn, is_file=True) | ||
| add("overwrite", "true") |
There was a problem hiding this comment.
Give each uploaded input a unique server-side name
When two driver instances use inputs with the same basename while another prompt is queued, both upload to the same ComfyUI input filename and the later invocation overwrites the first file before its LoadImage node necessarily executes. The first job can therefore process the second caller's image while reporting success to the first caller's output path; upload under a per-run UUID/subfolder rather than setting overwrite=true on a shared basename.
Useful? React with 👍 / 👎.
| if [ -z "$(git status --porcelain)" ]; then | ||
| echo "$(ts) clean: nothing to save" >>"$LOG"; exit 0 |
There was a problem hiding this comment.
Let push runs publish earlier autosave commits
Under the documented schedule of frequent commit-only runs plus a daily --push, the frequent run normally commits the edits first, so the daily invocation sees a clean tree and exits here before reaching git push. Previously created autosave commits therefore remain only on the disposable host unless new dirt happens to exist at push time; in --push mode, continue to the push even when there is nothing new to commit.
Useful? React with 👍 / 👎.
| git add -A | ||
| git commit -q -m "autosave $(ts): working-tree checkpoint" && echo "$(ts) committed locally" >>"$LOG" | ||
| if [ "${1:-}" = "--push" ]; then | ||
| if git push origin main >>"$LOG" 2>&1; then echo "$(ts) pushed to GitHub" >>"$LOG" |
There was a problem hiding this comment.
Push the commit from the checked-out branch
When the Unity checkout is on a feature branch or detached commit, the successful autosave commit is created at HEAD, but git push origin main uploads the unrelated local main ref. That push can exit successfully and log that GitHub was updated while the new checkpoint remains only on the host; either require and verify a main checkout before committing or push the actual HEAD to an explicitly selected remote ref.
Useful? React with 👍 / 👎.
| - Full box render caches (`Captures*`, `BuildOutput`) — regenerable; the curated renders live in | ||
| the WorldOS session-notes. | ||
|
|
||
| Backup location: `LEXAR/Codex/session-notes/2026-07-24/worldos-disk-cleanup-fork/artifacts/`. |
There was a problem hiding this comment.
Point the archive at the canonical mounted path
This is the sole locator given for artifacts deliberately omitted from Git, but LEXAR/Codex/... is a relative path and does not resolve to the canonical Mac artifact volume. An operator following it from the checkout cannot recover the archived-only scripts and caches; record the complete /Volumes/LEXAR/Codex/... path instead.
AGENTS.md reference: AGENTS.md:L6-L6
Useful? React with 👍 / 👎.
The GEX44 render box is being decommissioned. During a pre-shutdown sweep I found reusable WorldOS tooling that lived only on the box (in no git repo) and would have been lost with the hardware. This versions it under
tools/gex44-box/.The Unity project itself is safe — fully committed + pushed to
100yenadmin/worldos-unity-2026-06-30_07-21-47(incl. LFS); box working tree was clean and in sync (0 0), editor not running.What's preserved
worldos-unity-save.sh(the autosave/persistence contract),launch_editor.sh,derive_gbuffer.py,setup_depth.sh,INSTALL.md.All also archived at
LEXAR/…/2026-07-24/worldos-disk-cleanup-fork/artifacts/. The vLLM serving scripts (non-WorldOS) + regenerable render caches were archived to LEXAR but deliberately not committed. Path/location is easy to change in review.