feat(openworlds): expose companion camp beat history - #198
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
Cache: Disabled due to Reviews > Disable Cache setting 📝 WalkthroughWalkthroughThe PR projects camp beat history and cooldown metadata from snapshot state into the relations surface, adds tests for that projection, and wires the payload to the frontend where NPCDetail renders a new CampBeatLedger showing recent beats and cooldown readiness for the selected NPC. ChangesCamp Beat History Integration
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related issues
Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
Comment |
100yenadmin
force-pushed
the
viewer/companion-camp-surface
branch
from
May 26, 2026 18:50
caac76f to
281a9ed
Compare
100yenadmin
marked this pull request as ready for review
May 26, 2026 18:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the missing camp-beat visibility slice to the existing OpenWorlds relations surface. The repo already had factions, met NPCs, companion dossiers, and CompanionQuestArc projection wired; this PR makes the engine-owned
camp_beatshistory visible so issue #118 can be reviewed against a concrete UI/read-model path.What Changed
campBeatsto/relations-surfaceas a read-only projection:Architecture
The viewer remains a downstream projection layer. It reads the persisted
Campaign.camp_beatssnapshot shape and derives browser-safe display metadata. It does not callcamp_scene, does not schedule candidates, and does not record beats. The only write path for camp history remains the existing enginerecord_camp_beattool/API.This keeps the state-authority boundary intact:
Campaign.camp_beatsand all mutations;OSS Research Tie-In
This follows the roadmap-squeeze recommendation to build companion/camp UX natively rather than importing external VTT or generator code. External repos are useful as UX references here, but ClawDnD already has a domain-specific camp scheduler and companion model, so the fastest safe lift is exposing those existing engine facts.
Validation
Run from
/Volumes/LEXAR/repos/ClawDnD-companion-camp:All listed checks passed locally before opening this draft PR.
Rollback
Revert this PR to remove only the
campBeatsprojection and OpenWorlds companion camp section. Existing relations/faction/NPC/arc surfaces are otherwise unchanged.Refs #118, #58.
Summary by CodeRabbit
New Features