Skip to content

feat(openworlds): surface living-story read-models (betrayal-warning + quest-evolution) - #200

Merged
100yenadmin merged 1 commit into
mainfrom
viewer/living-story-readmodels
May 26, 2026
Merged

feat(openworlds): surface living-story read-models (betrayal-warning + quest-evolution)#200
100yenadmin merged 1 commit into
mainfrom
viewer/living-story-readmodels

Conversation

@100yenadmin

Copy link
Copy Markdown
Member

Desktop parallel lane — surfaces the new engine living-story features into the OpenWorlds app, in regions DISJOINT from the sibling lane's open PRs (per /tmp/desktop-lane-plan.md). RELATIONS (#118): a per-NPC betrayalWarning (the L2 danger band -40..-20, read-only, never leaks the sealed agenda) → a 'Bond fracturing' advisory. JOURNAL (#120): quest evolvesTo/callbackInDays + a threads array projecting evolves_from: consequences → a 'this thread will return' badge. Read-only projection (passes assert_no_private_keys). Rebased clean onto the L3 main. Tests: test_readmodel_surfaces.py green (6 new) + test_openworlds_static.py no regression. Icon-free (icon registry #182 not merged). Local-gated.

… read-models (#118/#120)

Project two newly-landed living-story engine features into the OpenWorlds
read-model surfaces, read-only (the viewer is a projection of engine state):

- Relations (#118): each companion row carries an advisory `betrayalWarning`
  (None unless live) recomputed from the snapshot, mirroring the engine's
  companion_arc._betrayal_warning danger band [-40, -20] — present only for a
  LIVE unfired attitude_below agenda below its breaking point. The relations
  screen renders a "Bond fracturing" telegraph beside the Approval gauge, and
  flags a choice-deepened rift via the engine-set decision flag. The sealed
  agenda's private intent never leaks.
- Journal (#120): each quest row carries evolvesTo/callbackInDays, and a new
  `_journal_evolutions` builder projects scheduled rule-of-three callbacks from
  consequences tagged `evolves_from:<quest_id>` (due / pending / fired), skipping
  worldsim background beats. The journal screen shows a per-quest "this thread
  will return" badge plus a "Threads & Callbacks" sub-list.

Icon-free (icon registry not yet merged); all changes confined to the disjoint
journal/relations builder regions + screens + test_readmodel_surfaces.py, no
sibling-PR files touched. Tests round-trip through the strict Campaign model.
@100yenadmin
100yenadmin merged commit af2c2b5 into main May 26, 2026
2 checks passed
@coderabbitai

coderabbitai Bot commented May 26, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@100yenadmin, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 4 minutes and 58 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: ecc38f91-87cb-406d-895b-7bc0e2cf973e

📥 Commits

Reviewing files that changed from the base of the PR and between a57570c and 21c8c03.

📒 Files selected for processing (4)
  • viewer/openworlds/screen-journal.jsx
  • viewer/openworlds/screen-relations.jsx
  • viewer/server.py
  • viewer/tests/test_readmodel_surfaces.py

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant