chore: clean public repository artifacts - #303
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughThis PR modernizes the WorldOS repository's development environment to support portable checkouts from any location by replacing hardcoded absolute paths (primarily from /Volumes/LEXAR) with home-directory-based defaults and relative paths. It simultaneously updates MCP configuration templating strategy, refines operational guidance to reflect new test policies, and performs cleanup of legacy documentation and test artifacts. ChangesPortable checkout environment
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related issues
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
script/unblock_native_app.sh (1)
35-35:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winUpdate stale operator-facing text to match WorldOS and primary env var.
These messages still reference
CLAWDND_REPO/“ClawDnD” even though the script now targets WorldOS and prefersWORLDOS_REPO. Please align the error/help text so operators get the correct override variable and product name.Proposed text-only cleanup
-if [ ! -d "$REPO" ]; then - err "repo not found at $REPO (set CLAWDND_REPO to override)"; exit 2 +if [ ! -d "$REPO" ]; then + err "repo not found at $REPO (set WORLDOS_REPO to override; CLAWDND_REPO is also supported)"; exit 2 fi @@ -step "Build + launch the ClawDnD app (prefers Developer ID, falls back to ad-hoc)" +step "Build + launch the WorldOS app (prefers Developer ID, falls back to ad-hoc)" @@ - printf "\n Open the ClawDnD window and click Resume / Forge a hero / Begin.\n Engine 1385/1385 ✓ · viewer 90/90 ✓ · all 14 screens render polished.\n\n" + printf "\n Open the WorldOS window and click Resume / Forge a hero / Begin.\n Engine 1385/1385 ✓ · viewer 90/90 ✓ · all 14 screens render polished.\n\n"Also applies to: 55-55, 75-75
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@script/unblock_native_app.sh` at line 35, Update the operator-facing error/help text to reference the correct product name and env var: replace occurrences of 'CLAWDND_REPO' and "ClawDnD" with 'WORLDOS_REPO' and "WorldOS" in the err messages that mention the repo override (e.g., the err call that currently reads 'repo not found at $REPO (set CLAWDND_REPO to override)'; exit 2 and the similar err/help strings found later in the script). Keep the same err function and $REPO usage, just change the literal text to mention WORLDOS_REPO and WorldOS so operators see the right override variable and product name.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@qa/run_duo.sh`:
- Line 41: The script currently rewrites package paths by unconditionally
substituting "/servers/" which duplicates segments for relative values like
"servers/engine"; update the normalization logic in run_duo.sh so it first
normalizes the extracted --directory value (trim any leading "./"), then build
the final path by: if the value already contains "/servers/" use it as-is
relative to ROOT, else if it starts with "servers/" join as "$ROOT/<dir>" (not
"$ROOT/servers/<dir>"), and otherwise prepend "$ROOT/servers/<dir>" — apply the
same fix to both places that handle the package directory extraction/rewrite
where the "/servers/" replacement is performed.
In `@WorldOS-RUNBOOK.md`:
- Around line 172-174: The phrase "gh pr merge --squash --admin" in the merge
flow description should be updated to match the CI-first policy; locate the
occurrences of that exact token/command (appearing in the lines that read "gh pr
merge --squash --admin") and replace them with wording that instructs to merge
via the normal PR path after CI checks pass (e.g., "merge after checks pass /
use the standard PR merge flow") and remove the explicit --admin bypass; apply
the same change to the other occurrence noted (also referenced around lines
392-393).
---
Outside diff comments:
In `@script/unblock_native_app.sh`:
- Line 35: Update the operator-facing error/help text to reference the correct
product name and env var: replace occurrences of 'CLAWDND_REPO' and "ClawDnD"
with 'WORLDOS_REPO' and "WorldOS" in the err messages that mention the repo
override (e.g., the err call that currently reads 'repo not found at $REPO (set
CLAWDND_REPO to override)'; exit 2 and the similar err/help strings found later
in the script). Keep the same err function and $REPO usage, just change the
literal text to mention WORLDOS_REPO and WorldOS so operators see the right
override variable and product name.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 42595442-1920-434e-8460-fae2a7863c6d
⛔ Files ignored due to path filters (32)
qa/runs/sweep-20260528-225614/shots/acts.pngis excluded by!**/*.pngqa/runs/sweep-20260528-225614/shots/bestiary.pngis excluded by!**/*.pngqa/runs/sweep-20260528-225614/shots/character.pngis excluded by!**/*.pngqa/runs/sweep-20260528-225614/shots/combat.pngis excluded by!**/*.pngqa/runs/sweep-20260528-225614/shots/create.pngis excluded by!**/*.pngqa/runs/sweep-20260528-225614/shots/dialogue.pngis excluded by!**/*.pngqa/runs/sweep-20260528-225614/shots/forge.pngis excluded by!**/*.pngqa/runs/sweep-20260528-225614/shots/inventory.pngis excluded by!**/*.pngqa/runs/sweep-20260528-225614/shots/journal.pngis excluded by!**/*.pngqa/runs/sweep-20260528-225614/shots/launcher.pngis excluded by!**/*.pngqa/runs/sweep-20260528-225614/shots/map.pngis excluded by!**/*.pngqa/runs/sweep-20260528-225614/shots/merchant.pngis excluded by!**/*.pngqa/runs/sweep-20260528-225614/shots/relations.pngis excluded by!**/*.pngqa/runs/sweep-20260528-225614/shots/seed.pngis excluded by!**/*.pngqa/runs/sweep-20260528-225614/shots/settings.pngis excluded by!**/*.pngqa/runs/sweep-20260528-225614/shots/table.pngis excluded by!**/*.pngqa/runs/sweep-20260528-233434/shots/acts.pngis excluded by!**/*.pngqa/runs/sweep-20260528-233434/shots/bestiary.pngis excluded by!**/*.pngqa/runs/sweep-20260528-233434/shots/character.pngis excluded by!**/*.pngqa/runs/sweep-20260528-233434/shots/combat.pngis excluded by!**/*.pngqa/runs/sweep-20260528-233434/shots/create.pngis excluded by!**/*.pngqa/runs/sweep-20260528-233434/shots/dialogue.pngis excluded by!**/*.pngqa/runs/sweep-20260528-233434/shots/forge.pngis excluded by!**/*.pngqa/runs/sweep-20260528-233434/shots/inventory.pngis excluded by!**/*.pngqa/runs/sweep-20260528-233434/shots/journal.pngis excluded by!**/*.pngqa/runs/sweep-20260528-233434/shots/launcher.pngis excluded by!**/*.pngqa/runs/sweep-20260528-233434/shots/map.pngis excluded by!**/*.pngqa/runs/sweep-20260528-233434/shots/merchant.pngis excluded by!**/*.pngqa/runs/sweep-20260528-233434/shots/relations.pngis excluded by!**/*.pngqa/runs/sweep-20260528-233434/shots/seed.pngis excluded by!**/*.pngqa/runs/sweep-20260528-233434/shots/settings.pngis excluded by!**/*.pngqa/runs/sweep-20260528-233434/shots/table.pngis excluded by!**/*.png
📒 Files selected for processing (30)
.claude/skills/worldos-dev/SKILL.md.gitignoreCHANGELOG.mdCLAUDE.mdWorldOS-RUNBOOK.mddocs/PRIVATE_COMPENDIUM_SIDECAR.mddocs/ui-audit/MASTER_TRACKER.mddocs/ui-audit/screens/character.mddocs/ui-audit/screens/launcher.mddocs/ui-audit/screens/table.mddocs/ui-audit/screenshots/README.mdqa/SCORECARD.mdqa/play_human.shqa/qa.mcp.example.jsonqa/run_combat_sprint.shqa/run_duo.shqa/run_party.shqa/run_qa.shqa/runs/sweep-20260528-225614/screen_coverage.jsonqa/runs/sweep-20260528-225614/screen_coverage.mdqa/runs/sweep-20260528-233434/screen_coverage.jsonqa/runs/sweep-20260528-233434/screen_coverage.mdscript/unblock_native_app.shscripts/license_check.pyservers/engine/server.pyservers/voice/playtest_voice.pyservers/voice/smoke_test.pytools/ingest/README.mdtools/ingest/private_compendium_sidecar.pyviewer/server.py
💤 Files with no reviewable changes (5)
- qa/runs/sweep-20260528-233434/screen_coverage.json
- qa/runs/sweep-20260528-225614/screen_coverage.md
- CLAUDE.md
- qa/runs/sweep-20260528-225614/screen_coverage.json
- qa/runs/sweep-20260528-233434/screen_coverage.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLAUDE.mdand ignore future local operator/agent artifactsqa/runsscreenshots/reports and ignore future QA run outputsqa/qa.mcp.jsonwith portableqa/qa.mcp.example.jsonValidation
pwdpython3 -m json.tool qa/qa.mcp.example.jsonbash -n qa/run_duo.sh qa/play_human.sh qa/run_combat_sprint.sh qa/run_party.sh qa/run_qa.sh script/unblock_native_app.shpython3 -m py_compile scripts/license_check.py tools/ingest/private_compendium_sidecar.py viewer/server.py servers/engine/server.py servers/voice/playtest_voice.py servers/voice/smoke_test.pypython3 scripts/license_check.pyUV_PROJECT_ENVIRONMENT=/Volumes/LEXAR/Codex/worldos-public-hygiene-engine-venv-20260529 uv run --directory servers/engine python -m pytest tests/test_private_compendium_sidecar.py -q -p no:xdistgit diff --checkgit diff --cached --checkgit ls-files -ci --exclude-standardCLAUDE.md,qa/qa.mcp.json, andqa/runsSummary by CodeRabbit