Fix Codex login probe in support VM preflight - #517
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe codex authentication probe mechanism is updated to use ChangesCodex Auth Probe Migration
Possibly Related PRs
Poem
Estimated Code Review Effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
Comment |
Summary
codex auth statusreadiness probe with the currentcodex login statuscommandsupport_vm_preflight.jsonfor operator reviewlogin statusand never calls the staleauth statuspathWhy
#466 depends on a trustworthy support-VM preflight before any heavy persona sweep. Current Codex CLI builds expose
codex login status;codex auth statusexits with an unrecognized-subcommand error, so the preflight would falsely block Codex readiness even when auth is configured.Tests
python3 -m pytest qa/test_support_vm_preflight.py -qpython3 -m pytest qa/test_support_vm_preflight.py qa/test_release_readiness.py -qpython3 -m py_compile qa/support_vm_preflight.pygit diff --check/Volumes/LEXAR/Codex/worldos-support-vm-preflight/local-codex-login-probe-6d107d6/support_vm_preflight.jsonprovedcodex_auth.auth_status=provenviacodex login statuswhile correctly remaining non-ready for unrelated local-worktree blockersLicensing / CLA
Summary by CodeRabbit
Bug Fixes
Tests