Skip to content

Fix Codex login probe in support VM preflight - #517

Merged
100yenadmin merged 1 commit into
mainfrom
codex/worldos-codex-login-preflight
Jun 1, 2026
Merged

Fix Codex login probe in support VM preflight#517
100yenadmin merged 1 commit into
mainfrom
codex/worldos-codex-login-preflight

Conversation

@100yenadmin

@100yenadmin 100yenadmin commented Jun 1, 2026

Copy link
Copy Markdown
Member

Summary

  • replace the unsupported codex auth status readiness probe with the current codex login status command
  • record the auth probe command in support_vm_preflight.json for operator review
  • add a regression test proving the preflight uses login status and never calls the stale auth status path

Why

#466 depends on a trustworthy support-VM preflight before any heavy persona sweep. Current Codex CLI builds expose codex login status; codex auth status exits with an unrecognized-subcommand error, so the preflight would falsely block Codex readiness even when auth is configured.

Tests

  • python3 -m pytest qa/test_support_vm_preflight.py -q
  • python3 -m pytest qa/test_support_vm_preflight.py qa/test_release_readiness.py -q
  • python3 -m py_compile qa/support_vm_preflight.py
  • git diff --check
  • local diagnostic preflight artifact: /Volumes/LEXAR/Codex/worldos-support-vm-preflight/local-codex-login-probe-6d107d6/support_vm_preflight.json proved codex_auth.auth_status=proven via codex login status while correctly remaining non-ready for unrelated local-worktree blockers

Licensing / CLA

  • I have submitted or will submit the required CLA if applicable.
  • This PR does not add third-party code or assets requiring new license review.
  • This PR does not include private art, secrets, credentials, or evidence bundles.

Summary by CodeRabbit

  • Bug Fixes

    • Updated authentication verification to use the current supported command method for Codex status checks.
  • Tests

    • Added test coverage to verify authentication probe functionality and command usage.

@coderabbitai

coderabbitai Bot commented Jun 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e44586ae-98b3-421c-ac92-ba2a4c6e67c9

📥 Commits

Reviewing files that changed from the base of the PR and between 6d107d6 and 1ead5bf.

📒 Files selected for processing (2)
  • qa/support_vm_preflight.py
  • qa/test_support_vm_preflight.py

📝 Walkthrough

Walkthrough

The codex authentication probe mechanism is updated to use codex login status instead of codex auth status. The implementation records the probe command name and evaluates the output using existing auth status logic. Test infrastructure is updated to support the new command, and a new test validates that the probe uses the supported login status subcommand without invoking the legacy auth status command.

Changes

Codex Auth Probe Migration

Layer / File(s) Summary
Codex login status authentication probe
qa/support_vm_preflight.py
The codex authentication probe in inspect_tools now executes codex login status instead of codex auth status, recording the command name in codex["auth_probe_command"] and evaluating output through existing authentication marker logic.
Test infrastructure and probe validation
qa/test_support_vm_preflight.py
FakeRunner initializes command recording earlier and emulates the codex login status probe. A new unit test (test_codex_auth_probe_uses_supported_login_status) validates that preflight.build_report successfully marks readiness using the login status probe without invoking the legacy auth status command.

Possibly Related PRs

  • electricsheephq/WorldOS#516: Updates Codex-specific readiness logic in the same files; this PR aligns auth probing with the Codex VM persona lane verification introduced there.
  • electricsheephq/WorldOS#508: Also modifies the Codex auth probing logic in the same test files; this PR switches the probe command to align with auth status probe implementation in that PR.

Poem

🐰 From auth to login, the probe takes flight,
Codex status checked with modern might,
Commands recorded, tests align,
A small refactor, clean and fine! ✨

Estimated Code Review Effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and concisely describes the main change: replacing the unsupported Codex auth status probe with the login status command in the support VM preflight.
Description check ✅ Passed The description includes all required template sections: a clear summary of changes, detailed reasoning for the fix, comprehensive test validation, and complete CLA/licensing checklist.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands and usage tips.

@100yenadmin
100yenadmin merged commit 9140cc4 into main Jun 1, 2026
14 checks passed
@100yenadmin
100yenadmin deleted the codex/worldos-codex-login-preflight branch June 1, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant