qa: pass split evidence through release gate

[100yenadmin]

Summary

• Adds --handoff-json and --support-preflight-json flags to qa/release_gate.sh.
• Forwards those evidence files into qa/release_readiness.py via an argv array so split Mac/remote evidence cannot bypass the support-preflight requirement added by the RRI contract.
• Updates the QA tools index with generic, public-safe guidance for split evidence rollups.

Public-Safety Check

• This PR does not add operator hostnames, remote checkout paths, auth-status output, private-art topology, artifact-return topology, or private evidence bundle paths.
• Diff scan was run before opening the PR.

Tests

• bash -n qa/release_gate.sh
• python3 -m pytest qa/test_release_gate_static.py -q
• python3 -m pytest qa/test_release_readiness.py -q
• git diff --check

Not a release verdict; this only tightens the release-gate evidence path.

Summary by CodeRabbit

• New Features

  • Added --handoff-json and --support-preflight-json CLI options to the release gate for passing Mac handoff and support VM preflight evidence.

• Bug Fixes

  • Release gate now validates evidence files exist and are readable before proceeding.
  • Missing or stale support-preflight evidence now causes release gate failure.

• Documentation

  • Updated QA instructions for Release Readiness Index rollup with remote/persona artifacts and Mac handoff proof.

• Tests

  • Enhanced release gate shell contract validation tests.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6f9ade2a-6ec7-459b-881e-c875d70e8b21

📥 Commits

Reviewing files that changed from the base of the PR and between bd93b84 and 2790f7f.

📒 Files selected for processing (3)

• qa/QA_TOOLS.md
• qa/release_gate.sh
• qa/test_release_gate_static.py

---

📝 Walkthrough

Walkthrough

The release-gate script now accepts optional --handoff-json and --support-preflight-json flags, validates their file presence, and conditionally forwards them to the Release Readiness Index rollup via an RRI_ARGS array. The documentation and contract tests confirm expected parsing and invocation behavior.

Changes

RRI Evidence Flow

Layer / File(s)	Summary
CLI Options and Argument Parsing qa/release_gate.sh	Added --handoff-json and --support-preflight-json CLI flags to the script's usage comment; extended argument parsing to recognize and store these options in top-level variables.
Input Validation qa/release_gate.sh	Added preflight checks that verify provided JSON paths exist and are readable; the gate aborts if validation fails.
RRI Invocation Refactoring qa/release_gate.sh	Refactored the RRI invocation to assemble RRI_ARGS array from conditional flags, then execute python3 qa/release_readiness.py "${RRI_ARGS[@]}" instead of a direct multi-line command.
Testing and Documentation qa/test_release_gate_static.py, qa/QA_TOOLS.md	Updated static contract test to assert new argument parsing and RRI_ARGS construction; added QA documentation clarifying the expected invocation path when passing handoff and support-preflight evidence.

Estimated Code Review Effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly Related PRs

• electricsheephq/WorldOS#524: Updates qa/release_readiness.py to validate and consume --support-preflight-json, directly paired with this PR's plumbing through qa/release_gate.sh.
• electricsheephq/WorldOS#521: Extends qa/release_readiness.py to consume --handoff-json and emit payload["handoff_evidence"], matching this PR's forwarding of the handoff flag into the RRI call.
• electricsheephq/WorldOS#508: Introduces qa/support_vm_preflight.py that generates the support_vm_preflight.json artifact that this PR now accepts and validates through the release gate.

Poem

🐰 The gate now guards both handoff dreams and preflight hopes so bright,
With flags aligned and args arrayed, the RRI sees the light.
From JSON files to readiness arrays, the artifacts flow free,
A rabbit's work, a tested path—release decisions made with glee! 🎉

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: adding and forwarding split evidence flags through the release gate script.
Description check	✅ Passed	The description covers the summary of changes, addresses public-safety concerns, and lists validation tests run, though the licensing/CLA checkbox section is not completed.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[100yenadmin]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[100yenadmin]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.