Improve first-turn action affordances - #535
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughThis PR enriches the chronicle data flow with event timestamps and action metadata to enable deterministic interleaving of player moves and narrative events. Server-side action models now include optional ChangesChronicle Enrichment with Event Time and Action Detail
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Possibly related issues
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
Comment |
Summary
Explorebutton detail text with distinct player-facing action affordances on the table paletteYOUrow renders before the DM reply when/chatandrecentEventsare mergedVerification
bash -n scripts/play_scripted_dm.shpython3 -m py_compile viewer/server.pypython3 -m pytest viewer/tests/test_session_surface.py viewer/tests/test_live_narration_stream.py viewer/tests/test_openworlds_static.py qa/test_macos_app_static.py -qcan_act=true, five enabled actions, visible action detailsPress onward/Speak aloud/Act in world/Roll a skill/Resist danger, one accepted/move,YOUrow before DM reply, no smoke-provider leak, no double period, zero browser console errors. Evidence archived outside the repo under/Volumes/LEXAR/Codex/worldos-product-slices/action-affordances-order-port8796-ac4423b/.Notes
Summary by CodeRabbit
Release Notes
New Features
Bug Fixes
Tests