Hide wrapper progress filler from Chronicle - #629
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR extends the narration sanitization logic to strip "wrapper-authored" generic progress placeholder lines that should not appear in story output. A new constant set and detection helper identify these placeholders, which are filtered out alongside existing internal advisory lines. Test coverage verifies placeholder-only inputs are fully removed and mixed content retains only non-placeholder prose. ChangesWrapper Progress Line Filtering
Possibly related PRs
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
Comment |
Summary
Evidence
2cba2a0showed typed Say, typed Do, and d20 all resolving, but the permanent Chronicle included canned wrapper lines such asThe world turns with your action; the scene shifts toward its answer./Volumes/LEXAR/Codex/worldos-product-slices/live-browser-2cba2a0-shortplay-20260603T020628Z//Volumes/LEXAR/Codex/worldos-product-slices/live-browser-2cba2a0-shortplay-20260603T020628Z/evidence-patched-viewer/patched-summary.json:banned_present=[],has_final_reply=true,has_player_move=true,image_probe_ok=true,network_failure_count=0Validation
python3 -m pytest viewer/tests/test_sanitize_narration.py -q-> 10 passed, 19 subtests passedpython3 -m pytest viewer/tests/test_openworlds_static.py -q-> 57 passed, 6 subtests passedgit diff --checkInvariants
Summary by CodeRabbit
Bug Fixes
Tests