Skip to content

Hide wrapper progress filler from Chronicle - #629

Merged
100yenadmin merged 1 commit into
mainfrom
codex/hide-wrapper-progress-scaffolding
Jun 3, 2026
Merged

Hide wrapper progress filler from Chronicle#629
100yenadmin merged 1 commit into
mainfrom
codex/hide-wrapper-progress-scaffolding

Conversation

@100yenadmin

@100yenadmin 100yenadmin commented Jun 3, 2026

Copy link
Copy Markdown
Member

Summary

  • hides the fixed Codex DM wrapper progress placeholders from the player-facing Chronicle
  • keeps real DM progress/final narration, player moves, images, and action state intact
  • adds sanitizer coverage for exact wrapper placeholders plus near-miss prose

Evidence

  • Browser-first live short play on current main 2cba2a0 showed typed Say, typed Do, and d20 all resolving, but the permanent Chronicle included canned wrapper lines such as The world turns with your action; the scene shifts toward its answer.
  • Evidence root: /Volumes/LEXAR/Codex/worldos-product-slices/live-browser-2cba2a0-shortplay-20260603T020628Z/
  • Patched viewer render against that same saved state: /Volumes/LEXAR/Codex/worldos-product-slices/live-browser-2cba2a0-shortplay-20260603T020628Z/evidence-patched-viewer/
  • patched-summary.json: banned_present=[], has_final_reply=true, has_player_move=true, image_probe_ok=true, network_failure_count=0

Validation

  • python3 -m pytest viewer/tests/test_sanitize_narration.py -q -> 10 passed, 19 subtests passed
  • python3 -m pytest viewer/tests/test_openworlds_static.py -q -> 57 passed, 6 subtests passed
  • git diff --check

Invariants

  • Engine remains sole campaign-state writer.
  • GUI/viewer change is read/projection only.
  • This is product-polish evidence, not an RRI/release verdict.

Summary by CodeRabbit

  • Bug Fixes

    • Improved narration sanitization to filter out generic progress placeholder lines from story content, resulting in cleaner story display.
  • Tests

    • Added test coverage to verify placeholder narration filtering works as expected.

@coderabbitai

coderabbitai Bot commented Jun 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e820639e-e1b9-48d6-9e20-8bb9ed6b90f7

📥 Commits

Reviewing files that changed from the base of the PR and between 2cba2a0 and b126537.

📒 Files selected for processing (2)
  • viewer/openworlds/screen-table.jsx
  • viewer/tests/test_sanitize_narration.py

📝 Walkthrough

Walkthrough

This PR extends the narration sanitization logic to strip "wrapper-authored" generic progress placeholder lines that should not appear in story output. A new constant set and detection helper identify these placeholders, which are filtered out alongside existing internal advisory lines. Test coverage verifies placeholder-only inputs are fully removed and mixed content retains only non-placeholder prose.

Changes

Wrapper Progress Line Filtering

Layer / File(s) Summary
Wrapper progress line filtering
viewer/openworlds/screen-table.jsx, viewer/tests/test_sanitize_narration.py
Add _WRAPPER_PROGRESS_LINES constant and _isWrapperProgressLine() helper to identify wrapper progress placeholder narration. Extend sanitizeNarration() filter to drop these lines. Test test_wrapper_progress_placeholders_do_not_become_story() verifies pure placeholders are stripped while mixed content and non-placeholders are handled correctly.

Possibly related PRs

  • electricsheephq/WorldOS#628: Both PRs modify sanitizeNarration() post-processing and extend test_sanitize_narration.py at the same filtering checkpoint.
  • electricsheephq/WorldOS#532: Introduces wrapper-emitted progress placeholder narration lines that this PR then filters from story output.
  • electricsheephq/WorldOS#338: Prior update to sanitizeNarration() filtering logic in the same code path for removing internal advisory and tool lines.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 No more progress ghosts in tales we tell,
Wrapper placeholders sent to filtering's shell,
Constants and helpers keep stories clean,
The finest prose now reaches the screen!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Hide wrapper progress filler from Chronicle' clearly and concisely describes the main change: removing wrapper progress placeholder lines from the player-facing Chronicle.
Description check ✅ Passed The description includes a Summary section explaining the changes, Evidence with specific details and validation artifacts, comprehensive Validation section with test results, and Invariants. However, it is missing the required 'Licensing / CLA' section from the template.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands and usage tips.

@100yenadmin
100yenadmin marked this pull request as ready for review June 3, 2026 02:19
@100yenadmin
100yenadmin merged commit ff428a8 into main Jun 3, 2026
14 checks passed
@100yenadmin
100yenadmin deleted the codex/hide-wrapper-progress-scaffolding branch June 3, 2026 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant