feat(openworlds): create — subrace handling on the Creation Plane (#377, #315 AC5)

[100yenadmin]

Closes #377. Implements #315 AC5 (subrace handling on the Creation Plane).

What changed

Subrace is now an optional second-tier lineage choice on the Creation Plane, threaded through the ability preview, the review/summary surfaces, the portrait filter, and the startProviderSession seam.

Additive, render-only (viewer JSX, no build step). Validated by transforming screen-create.jsx through viewer/openworlds/vendor/babel-standalone-7.29.0.min.js (62393 transformed bytes, plus a negative control proving the validator fails on broken JSX).

viewer/openworlds/screen-create.jsx

• AC1 — data model: RACES entries gain an optional subraces map — elf (high/wood), dwarf (mountain/hill), halfling (lightfoot/stout), gnome (forest/rock). Each subrace declares name, optional body, and a bonus delta that stacks on the base race.
  • Drow decision (documented in source): drow stays a standalone top-level race (it already has its own RACES entry, its own CHA delta, and a Minthara gallery face tagged race:"drow"), not folded into elf.subraces. Only High/Wood live under elf so the gallery filter + race tags stay consistent with what's already shipped.
• Helpers: subracesForRace / hasSubraces / mergeBonus (additive, non-mutating) / effectiveRaceBonus (base + chosen subrace) / subraceLineageName.
• AC2 — UI: new SubracePicker renders brass/sketch radio chips, gated on the selected race having a non-empty subraces map. A synthesized "Standard" option (subrace: null) is first and is the default, so base-race-only / homebrew heroes are never blocked. Switching race clears a stale subrace (a Wood Elf pick can't linger onto Dwarf). role="radiogroup"/role="radio" + data-worldos-testid hooks for agent driving.
• AC3 — ability stacking: the StepAbilities preview, the StepReview summary, and the live right-rail summary all read effectiveRaceBonus(hero). Mountain Dwarf shows STR +2 / CON +2; no surface is left reading the bare base-race bonus.
• AC4 — bindHero spec: spec.subrace is serialized (string slug, empty string when none chosen) across the startProviderSession seam alongside race. Engine-side wiring is out of scope (filed separately if needed).
• Initial hero state gains a subrace: null slot.
• [playtest] Creation Plane: image selection still incorrect — race-aware filter + larger gallery + dead-filter #315 AC5 — portraits: portraitChoicesForRace(race, subrace) ANDs in the subrace when the gallery carries subrace-tagged faces, else degrades to the race-level pool (never an empty grid — the curated 12-face set is race-only today). Preserves the existing fix(openworlds): portrait gallery empty for 5 of 11 races (dwarf, halfling, gnome, dragonborn, half-orc) #379/fix(openworlds): portrait gallery empty-state fallback (Closes #379) #390 race-level fallback.

viewer/tests/test_openworlds_static.py

• test_openworlds_create_subrace_handling_is_wired: parses RACES per-race and asserts the four subrace maps + bonus deltas, the drow-standalone decision, the SubracePicker / radiogroup / Standard-default UI, the single effectiveRaceBonus stacking path, the race-switch reset, the bindHero spec.subrace, and the subrace-aware portrait filter.

Verification

• JSX transforms cleanly through the vendored babel-standalone (no build step); negative control confirms the validator rejects broken JSX.
• Runtime smoke of the pure helpers: Mountain Dwarf STR+2/CON+2, Hill Dwarf CON+2/WIS+1, High Elf DEX+2/INT+1, Wood Elf DEX+2/WIS+1, Standard = base-only, mergeBonus non-mutating, lineage name = "Wood Elf", and wood-elf portrait grid stays non-empty.
• viewer/tests/test_openworlds_static.py, test_portrait_art.py, test_building_universe.py, and the non-subprocess test_portrait_gen.py classes: 96 passed.
• One pre-existing failure unrelated to this PR: test_portrait_gen.py::PortraitGenRealSubprocessTests::test_null_default_returns_placeholder_no_network fails with ModuleNotFoundError: No module named 'pydantic' — it spawns the real engine subprocess via uv run and the engine venv in this environment lacks the dep. That test file is byte-identical to HEAD; this PR touches only the JSX screen + its static guard.

Findings skipped

None — all four acceptance criteria of #377 are implemented.

Out of scope (untouched)

Parity lane, combat/table/character screens, the server.py combat/lockout area, scripts/play_party.sh, qa/run_duo.sh. No viewer/server.py change was needed (this is a wire-up + data change in the screen).

[coderabbitai]

Warning

Review limit reached

@100yenadmin, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 44 minutes and 45 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c65afb51-c0d1-4e08-b34a-5d87a257220f

📥 Commits

Reviewing files that changed from the base of the PR and between 411a07f and 5c5a47a.

📒 Files selected for processing (2)

• viewer/openworlds/screen-create.jsx
• viewer/tests/test_openworlds_static.py

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}