Document Codex GPT-DM fair-test lane - #692
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughAdds Codex CLI config-drift checks (service_tier parsing and blocker for Codex ≥0.128.0), integrates the check into preflight inspect_tools/readiness/reporting (including environment snapshot propagation), and supplies tests, a Mac runbook section, and a script to create an isolated CODEX_HOME for fair-test runs. ChangesCodex Config Drift Validation
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related issues
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@qa/support_vm_preflight.py`:
- Around line 176-177: The current fallback uses "env or os.environ" which
treats empty dicts as falsy and wrongly falls back to the host environment;
replace that pattern with an explicit None check so an explicit empty mapping
(e.g., {}) is preserved. Change occurrences that set env (the assignment using
env or os.environ) to use "if env is None: env = os.environ" (or equivalent
None-coalescing logic) and keep the subsequent CODEX_HOME lookup as-is (home =
(env.get("CODEX_HOME") or "").strip()). Update all three spots where env is
currently set via the "env or ..." pattern so tests and environment snapshots
respect an explicit empty env.
- Around line 183-192: The function parse_codex_service_tier currently matches
service_tier anywhere; restrict it to truly top-level by stopping parsing once a
TOML section header is seen. Update parse_codex_service_tier to iterate lines as
before but break out (or ignore subsequent matches) when encountering a line
matching a section header pattern like r'^\s*\[.*\]'; only attempt the
service_tier regex (the existing r"""service_tier\s*=\s*(['"]?)([^'"\s#]+)\1""")
on lines before that point (use the existing stripped variable and return
match.group(2).strip() as before).
In `@qa/test_support_vm_preflight.py`:
- Around line 193-210: The test method
test_codex_cli_0128_allows_fast_or_unset_service_tier currently only writes
service_tier = "flex" and asserts that preflight.build_report returns "flex";
either add a second case that covers the "unset" (remove service_tier from
codex_home/config.toml) or "fast" value and assert the expected report fields
(use FakeRunner with codex_version="codex-cli 0.128.0" and call
preflight.build_report the same way), or rename the test to something like
test_codex_cli_0128_allows_flex_service_tier to match the current assertion;
update assertions on report["tools"]["codex_auth"]["config"]["service_tier"] (or
absence thereof) accordingly.
In `@WorldOS-RUNBOOK.md`:
- Around line 284-289: The recorded result for "`#691`" shows a future-dated
evidence timestamp "2026-06-07"; update the date to the actual evidence date
used for that run (match the real timestamp associated with commit/hash
`93df5d2` and the `#691` run), ensuring the date format matches the rest of
WorldOS-RUNBOOK.md entries and update any related mention of `#691` or `93df5d2`
in the document to keep chronology consistent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: d2ed4ef4-995f-4fad-b48d-9c4ba943cd01
📒 Files selected for processing (4)
WorldOS-RUNBOOK.mdqa/support_vm_preflight.pyqa/test_support_vm_preflight.pyscripts/codex_qa_home.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/codex_qa_home.shto create an isolated Codex QA home without copying credentialsqa/support_vm_preflight.pyto block Codex CLI >=0.128 config drift when effectiveservice_tieris stale (defaultinstead of unset/fast/flex)Licensing / CLA
CLA.mdand submit this contribution under the WorldOS Contributor License Agreement.Evidence
worldos-codex-fair-test/gpt-5.5: Tolkien 3.1, Angry-DM 3.5, behavioral REDgpt-5.4: Tolkien 2.4, Angry-DM 3.3, behavioral REDTests
python3 -m pytest qa/test_support_vm_preflight.py -qbash -n scripts/codex_qa_home.shCODEX_HOME=/Users/lume/.codex-worldos-qaverifiedcodex_config_ready=truewhile blocking on the intentionally dirty worktree and missing Playwright in that edit worktreeRefs #691
Summary by CodeRabbit
New Features
Documentation
Tests