Skip to content

ci: gate the qa/ release-gate + scoring tests (closes #729) #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
100yenadmin merged 1 commit into from
Jun 9, 2026
Merged

ci: gate the qa/ release-gate + scoring tests (closes #729) #737

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,29 @@
# -p no:xdist keeps this single-process (no parallel workers) — lean by design.
run: python -m pytest viewer/tests -q -p no:xdist

qa-release-gate-tests:
# #729: the qa/ release-gate + scoring + wrapper-contract tests were NEVER in CI — the `test`
# job only collects servers/*/tests/. A *tested* crash (#723 `build_shas`, caught by
# test_release_readiness.py's 4 build_sha tests) shipped because CI never ran them. Gate the
# release-authority surface (release_readiness.py, scores_db.py, the play-wrapper contracts) so
# a regression there can no longer merge green.
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Install uv
uses: astral-sh/setup-uv@v5
- name: QA release-gate + scoring + wrapper-contract tests
# Run from the engine venv (pydantic etc. on path) with cwd=servers/engine, so the qa tests'
# `import server/store` resolves and release_readiness.py subprocesses use the same interpreter.
run: |
uv run --directory servers/engine --group dev python -m pytest -q -p no:xdist \
../../qa/test_release_readiness.py \
../../qa/test_release_readiness_scope.py \
../../qa/test_scores_db_comparability.py \
../../qa/test_scores_db.py \
../../qa/test_release_gate_static.py

license-check:

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand Down
Loading