test(qa): align PART_A_DEADLINE regression with FIX 3's derived, liveness-aware contract - #970
Merged
Merged
Conversation
…ness-aware contract (#623) test_coldopen_part_a_poll_window_outlasts_max_effort_coldopen pinned the literal `PART_A_DEADLINE="${WOS_APP_PART_A_DEADLINE:-420}"` and the old `seq 1 "$part_a_polls"` for-loop — both of which FIX 3 (#623, shipped in #966) intentionally replaced. #966's fast_gate doesn't run test_adversarial_release.py, so the stale test slipped through and left main RED. The production code is correct: 420 was SHORTER than the cold-open's own model-aware timeout (clawdnd_dm_timeout 1 = 500/550s), so a healthy-but-slow mint was abandoned ~80s early — the exact flake the test NAME warns about. FIX 3 derives the deadline FROM that tier + a positive margin and makes the poll liveness-aware. Rewrite the test to assert that *contract* semantically (extract the margin via regex, assert it's > 0 = the real "outlasts" guarantee; assert the hard-deadline + coldopen_is_live grace; keep the no-hardcoded-`seq 1 70` guard) — so a regression to a flat / too- short / non-positive-margin deadline now fails here, but the intended derivation passes. Test-only; 18/18 in test_adversarial_release.py green; fast_gate 222 intact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main was RED.
test_coldopen_part_a_poll_window_outlasts_max_effort_coldopenpinned the literalPART_A_DEADLINE=...:-420+ the oldseq 1 "$part_a_polls"for-loop — both intentionally replaced by FIX 3 (#623, shipped in #966). #966's fast_gate doesn't exercisetest_adversarial_release.py, so the stale test slipped.The code is correct (420 < the cold-open's own 500/550s timeout → abandoned a healthy-but-slow mint early; FIX 3 derives the deadline from that tier + a positive margin + makes the poll liveness-aware). This rewrites the test to assert the new contract semantically — extract the margin via regex and assert it's >0 (the real "outlasts" guarantee), assert the hard-deadline +
coldopen_is_livegrace, keep the no-hardcoded-seq 1 70guard. A regression to a flat/too-short/non-positive deadline now fails; the intended derivation passes.Test-only. 18/18 in test_adversarial_release.py green; fast_gate 222 intact.