Skip to content

fix(analyze): keep vector repair preflight byte-preserving - #179

Merged
100yenadmin merged 2 commits into
mainfrom
fix/repair-vector-readonly-preflight
Jul 22, 2026
Merged

fix(analyze): keep vector repair preflight byte-preserving#179
100yenadmin merged 2 commits into
mainfrom
fix/repair-vector-readonly-preflight

Conversation

@100yenadmin

Copy link
Copy Markdown
Member

Closes the release-blocking no-mutation defect tracked in #162.

The exact electric.7 artifact correctly rejected malformed WorldOS embedding identity, but a writable Ladybug open changed database bytes before rejection. This change adds a strict read-only, non-recovering preflight that never quarantines/replays/opens writable; only clean nonzero identity proceeds to writable HNSW maintenance.

Proof:

  • 13 focused unit/integration tests pass
  • real Ladybug malformed fixture preserves exact database bytes and storage entries
  • copied 519,897,088-byte WorldOS artifact rejects with the expected integrity error and retains SHA-256 7cc5b28a...
  • typecheck, build, formatting, and diff checks pass

Release remains held until this head merges and the exact artifact passes ClawSweeper plus immutable WorldOS acceptance.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 57 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 68bc12bd-fb2b-44a7-a87d-1c0447ea11ab

📥 Commits

Reviewing files that changed from the base of the PR and between 87b542a and 6fd0807.

📒 Files selected for processing (5)
  • gitnexus/src/core/lbug/lbug-adapter.ts
  • gitnexus/src/core/run-analyze.ts
  • gitnexus/test/integration/vector-repair-readonly-preflight.test.ts
  • gitnexus/test/unit/lbug-maintenance-lock.test.ts
  • gitnexus/test/unit/run-analyze-vector-repair.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/repair-vector-readonly-preflight

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

✨ PR Autofix

Found fixable formatting / unused-import issues across 11 changed lines. Comment /autofix on this PR to apply them, or run npm run lint:fix && npm run format locally.

{"schema":"gitnexus.pr-autofix/v2","state":"fixes-available","pr_number":179,"changed_lines":11,"head_sha":"fbf3d8fc5d457ea1a146a3f439b975d780f4b92d","run_id":"29933892614","apply_command":"/autofix"}

@evaos-code-review-bot

evaos-code-review-bot Bot commented Jul 22, 2026

Copy link
Copy Markdown

evaOS review status: completed

PR: #179 - fix(analyze): keep vector repair preflight byte-preserving
Head: 6fd08078988c2fd729306902d79ae6a4e2f1313b
Updated: 2026-07-22T15:47:42.820Z

evaOS review completed for this PR head.

Automation note: agents should wait for this comment to reach completed, stale_head, closed_or_merged_before_review, skipped, or failed before treating evaOS review as settled for this head. provider_deferred means evaOS still intends to retry.

PR URL: #179

Review URL: #179 (review)

@evaos-code-review-bot evaos-code-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Walkthrough

PR: #179 - fix(analyze): keep vector repair preflight byte-preserving
Head: 6fd08078988c2fd729306902d79ae6a4e2f1313b into main. Review event: COMMENT.
Provider: GLM/Z.ai through ZCode (zcode-glm, zcode, model GLM-5.2).

Estimated review effort: 1/5 (~10 min)

Changed Files

File Status Churn Purpose Risk

Review Signal

No validated inline findings.
Dropped findings before posting: 2. High-severity findings: 0.

Risk Taxonomy

No finding categories.

Validation and Proof

1 required validation/proof recommendation(s) selected from changed files.

  • required: TypeScript/web build or CI proof - Runtime TypeScript/web files or package/config files changed. Proof: npm run build; typecheck; focused Vitest; green GitHub check.
    Proof status: sufficient - PR metadata mentions acceptable proof for each required validation recommendation.
    Profile validation hints: Call out stale index, wrong repo identity, memory growth, and destructive analyze behavior.
    Profile proof expectations: Look for focused CLI, index, query, or migration proof.

Related Context

Related issues/PRs: #162.
Suggested labels: none.
Suggested reviewers: none from current metadata.

Review Settings Preview

  • Profile: assertive
  • Enabled sections: Review summary (inline_review); Walkthrough (inline_review); Changed-files table (walkthrough); Effort estimate (walkthrough); Related issues/PRs (walkthrough); Suggested labels (suggestion_only); Review status comment (sticky_status)
  • Path instructions: none
  • Label suggestions: gitnexus, code-intelligence, backend
  • Reviewer suggestions: none
  • Suggestion behavior: suggestions only; labels and reviewers are not auto-applied.
  • Roadmap-only settings: auto-apply labels; auto-request reviewers; required status checks

Pre-merge checklist

  • Inline comments target current RIGHT-side diff lines.
  • No secret-like content survived into posted inline comments.
  • REQUEST_CHANGES is only used when eligible P0/P1 findings survive validation.
  • Required behavior proof is present or not applicable.
  • Labels and reviewers are suggestions only; the bot did not auto-apply them.

@github-actions

Copy link
Copy Markdown

CI Report

All checks passed

Pipeline Status

Stage Status Details
✅ Typecheck success tsc --noEmit
✅ Tests success unit tests, 3 platforms
✅ E2E success gitnexus-web changes only

Test Results

Tests Passed Failed Skipped Duration
14939 14876 0 63 20s

✅ All 14876 tests passed

63 test(s) skipped — expand for details

Code Coverage

Tests

Metric Coverage Covered Base Delta Status
Statements 80.99% 56571/69843 N/A% 🟢 ████████████████░░░░
Branches 68.21% 34913/51184 N/A% 🟢 █████████████░░░░░░░
Functions 87.12% 6577/7549 N/A% 🟢 █████████████████░░░
Lines 84.49% 50560/59835 N/A% 🟢 ████████████████░░░░

📋 View full run · Generated by CI

@100yenadmin
100yenadmin merged commit fd6a4ff into main Jul 22, 2026
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant