chore: use ts config for electron-builder#236
Open
yaindrop wants to merge 1 commit intoelectron-vite:mainfrom
Open
chore: use ts config for electron-builder#236yaindrop wants to merge 1 commit intoelectron-vite:mainfrom
yaindrop wants to merge 1 commit intoelectron-vite:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I noticed that in a recent commit the
electron-builder.json5was changed toelectron-builder.jsonand a JSON schema was included, which is great. Since we are at it, why not just use the.config.tsformat, which allows either a config object or a function returning a config object according to https://www.electron.build/configuration.It aligns well with other configurations like
vite.config.ts, provides better IntelliSense than JSON schema, and allows easy future customization if the config shall ever be generated by a function.What is the purpose of this pull request?