build: fix yarn errors upon npm install minidump#95
Open
Jimbly wants to merge 1 commit intoelectron:mainfrom
Open
build: fix yarn errors upon npm install minidump#95Jimbly wants to merge 1 commit intoelectron:mainfrom
npm install minidump#95Jimbly wants to merge 1 commit intoelectron:mainfrom
Conversation
erickzhao
reviewed
Dec 12, 2024
- Only run `git submodule update` when running out of a git working copy - Don't require `yarn` for end-user installation
67687ac to
9f969f1
Compare
Author
|
Updated (and force-pushed) to remove trailing command that was causing a style check failure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
git submodule updatewhen running out of a git working copyyarnfor end-user installation (or any installation, since it's not listed as a dep)Closes #93
This fixes the following 3 errors:
development without yarn installed globally
end-user installing of minidump (or any package depending on it) without yarn installed locally or globally
end-user installing of minidump (or any package depending on it) in a non-git-controlled working directory:
Note: simply reverting 4be7737 will solve the last two end-user problems, presumably a situation like the first one was what that commit was attempting to solve (and it did solve it, as long as you have yarn installed globally, which, as far as I know, is not generally recommended), hopefully my addition to build.js will solve more elegantly solve the development case without needing to add external (non-dev) dependencies.