Features/update for tsc spec compliance#1
Merged
Conversation
…: `features/updates-for-tsc-spec-compliance` - This in turn results in updates of the other vendored dependencies
…ent` and `PaymentACK`
… to the latest version of `go-dpp` feature branch commit
…-tsc-spec-compliance`
…the `JSONEnvelope` based signed model. This also removes `payd` as a dependency, although there are remnants of configuration variables.
… runtime error: invalid memory address or nil pointer dereference'. Generate the swagger update.
- This includes relayed `payment.error` messages over the websocket from the payee (for example: `bad-txns-premature-spend-of-coinbase`)
… fields of the dpp.PaymentACK struct (as this is not a part of the TSC specification) - The payee wallet returns a `server.ClientError` in the body of the `payment.error` websocket message (this has not changed) and this is parsed and translated into the appropriate http error response. The `PaymentACK` was being inappropriately used in some cases as a way to pass around error details. This is no longer the case. - A `PaymentACK` object is only returned in the cased of successful payment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an old PR from here: bitcoin-sv#57
The description below has merely been copied over.
Merging this into an ElectrumSV dedicated fork as this is what the ElectrumSV develop branch has been running against for quite some time now (Jul 2022).
As discussed with @jadwahab and @sirdeggen here is the PR for the latest TSC spec: https://tsc.bitcoinassociation.net/standards/direct_payment_protocol/
Corresponding dual PR here: libsv/go-dpp#69
So far this only updates the
PaymentRequeststructure which is enough for now to get ElectrumSV through the first part of the data flow for development...Still to do:
PaymentPaymentACKUntil the
dpp-proxyis updated to the TSC spec, ElectrumSV will be building against this feature branch to avoid technical debt of the old message structures.