Migrate to pnpm#519
Open
florianduros wants to merge 4 commits into
Open
Conversation
florianduros
force-pushed
the
florianduros/pnpm
branch
from
d37d756 to
64b6351
Compare
Deploying compound-web with
|
| Latest commit: |
545bc5c
|
| Status: | 🚫 Build failed. |
florianduros
force-pushed
the
florianduros/pnpm
branch
2 times, most recently
from
63c432b to
900c230
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
florianduros
force-pushed
the
florianduros/pnpm
branch
from
900c230 to
11f5be6
Compare
florianduros
requested review from
Half-Shot and
MidhunSureshR
and removed request for
a team
dbkr
reviewed
Jul 2, 2026
| run: pnpm install --frozen-lockfile --ignore-scripts | ||
|
|
||
| - name: 🚧 Build | ||
| run: pnpm build |
Member
There was a problem hiding this comment.
sonar is probably right to want ignore scripts here (and elsewhere)
Member
Author
There was a problem hiding this comment.
Yes, a sane approach
Member
There was a problem hiding this comment.
pnpm has a whole allowBuilds thing where you allowlist scripts on a per-dep basis and Sonar doesn't consider it
| "@storybook/addon-docs": "^10.3.1", | ||
| "@storybook/addon-links": "^10.3.1", | ||
| "@storybook/addon-themes": "^10.3.1", | ||
| "@storybook/react": "^10.3.1", |
Member
Author
There was a problem hiding this comment.
pnpm and yarn don't organize the deps at the same level. We are using these deps without declaring them (they are deps of other deps) and moving to pnpm flaged it.
dbkr
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces Yarn with pnpm as the package manager.
"packageManager": "pnpm@11.9.0"topackage.jsonand replacedyarn.lockwithpnpm-lock.yamlanalysis.yml,npm_release.yml,storybook.yml) to usepnpm/action-setupand pnpm commandsyarn …references inpackage.jsonscripts topnpm …pnpm-workspace.yamlwith anallowBuildsallowlist to control native addon compilation@storybook/reactand@floating-ui/react-domwhich were implicit transitive dependencies not declared directlyyarn linkworkaround (no longer applicable with pnpm's symlink-based linking)pnpm-lock.yamlto.prettierignoreCaution
PR should be merged at the same time than the cloudflare settings update.
Cloudflare settings should be updated to use
pnpm install --frozen-lockfile --ignore-scripts && pnpm build-storybookto deploy storybook.