Skip to content

Translations for the "verify device before October" banner.#8018

Merged
pixlwave merged 4 commits into
developfrom
mxandreas/verify-banner-translations
Apr 29, 2026
Merged

Translations for the "verify device before October" banner.#8018
pixlwave merged 4 commits into
developfrom
mxandreas/verify-banner-translations

Conversation

@mxandreas
Copy link
Copy Markdown
Member

Pull Request Checklist

  • I read the contributing guide
  • UI change has been tested on both light and dark themes, in portrait and landscape orientations and on iPhone and iPad simulators
  • Accessibility has been taken into account.
  • Pull request is based on the develop branch
  • Pull request contains a changelog file in ./changelog.d
  • You've made a self review of your PR
  • Pull request includes screenshots or videos of UI changes
  • Pull request includes a sign off

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 23, 2026

CLA assistant check
All committers have signed the CLA.

Comment thread Riot/Assets/de.lproj/Vector.strings Outdated

// Verification Required Banner
"verification_required_banner_title" = "Verifiziere dieses Gerät";
"verification_required_banner_description" = "As of April 2026 unverified devices will not be able to send and receive messages";
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"verification_required_banner_description" = "As of April 2026 unverified devices will not be able to send and receive messages";
"verification_required_banner_description" = "Ab Oktober 2026 können nicht verifizierte Geräte keine Nachrichten mehr senden und empfangen";

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have Ab Oktober 2026 können unverifizierte Geräte keine Nachrichten mehr senden und empfangen. on Android (in element-hq/element-android#9141) not sure what's best but both translations should match.

Comment thread Riot/Assets/de.lproj/Vector.strings Outdated
"verification_required_banner_title" = "Verifiziere dieses Gerät";
"verification_required_banner_description" = "As of April 2026 unverified devices will not be able to send and receive messages";
"verification_required_banner_learn_more" = "Mehr erfahren";
"verification_required_banner_verify_button" = "Verify now"; No newline at end of file
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"verification_required_banner_verify_button" = "Verify now";
"verification_required_banner_verify_button" = "Jetzt verifizieren";

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 13.72%. Comparing base (02dd8ab) to head (b380b87).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8018      +/-   ##
===========================================
- Coverage    16.57%   13.72%   -2.86%     
===========================================
  Files         1815     1815              
  Lines       124242   173520   +49278     
  Branches     49149    73657   +24508     
===========================================
+ Hits         20593    23809    +3216     
- Misses      102992   149045   +46053     
- Partials       657      666       +9     
Flag Coverage Δ
uitests 59.68% <ø> (+9.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mxandreas mxandreas marked this pull request as ready for review April 29, 2026 12:21
@pixlwave
Copy link
Copy Markdown
Member

Failing tests are the usual flakey ones.

@pixlwave pixlwave merged commit 917adc8 into develop Apr 29, 2026
7 of 9 checks passed
@pixlwave pixlwave deleted the mxandreas/verify-banner-translations branch April 29, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants