Only load full media on media viewer when it's the visible item#6794
Open
jmartinesp wants to merge 3 commits into
Open
Only load full media on media viewer when it's the visible item#6794jmartinesp wants to merge 3 commits into
jmartinesp wants to merge 3 commits into
Conversation
Contributor
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #6794 +/- ##
===========================================
- Coverage 81.29% 81.28% -0.01%
===========================================
Files 2648 2648
Lines 74122 74134 +12
Branches 9606 9614 +8
===========================================
+ Hits 60255 60259 +4
- Misses 10323 10328 +5
- Partials 3544 3547 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Content
In the media viewer screen:
Motivation and context
Fixes #6792.
What's not addressed but could also be useful:
Screenshots / GIFs
No UI changes, I hope.
Tests
Open the media viewer in a room where you have a mix of images and videos. Check the logs only contain
/downloadlog lines for the current item, and if you scroll fast enough you see logs for cancelled downloads.Tested devices
Checklist