Remove wall-clock dependency of test_redact_messages_all_rooms test.#19890
Merged
Conversation
sandhose
approved these changes
Jul 1, 2026
erikjohnston
approved these changes
Jul 1, 2026
reivilibre
changed the title
test_redact_messages_all_rooms test, as this caused flakiness.
27 tasks
Comment on lines
+5790
to
+5791
| # Need 1 tick as we send 1 replication request per original event | ||
| # and each wait must be >= `_EPSILON` from `http/client.py` |
Contributor
There was a problem hiding this comment.
I'm updating this description further in #19871 as I'm also making other related changes. Thanks for making this more precise!
Suggested change
| # Need 1 tick as we send 1 replication request per original event | |
| # and each wait must be >= `_EPSILON` from `http/client.py` | |
| # `/redact` just schedules a background task that runs in the background | |
| # (fire-and-forget) so we need to do the waiting here. | |
| # | |
| # Need 1 tick as we send 1 replication request for the redaction of each | |
| # original event. The replication request body is streamed by a `Cooperator` | |
| # that uses the clock to schedule each chunk at a tiny *non-zero* delay | |
| # (`CLOCK_SCHEDULE_EPSILON`), so we need to actually advance the clock for it to | |
| # fire. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced in: #17847
This 10-second wall-clock timeout was troublesome as it fails on slow/struggling CI runners, like the
default ones for private GitHub repositories.
The loop also silently relied on the reactor advance in
make_request,whereas we could just deterministically advance the reactor the known amount of times
instead.