Added ability to set attributes on body in HTMLDocument types#94
Merged
sliemeobn merged 3 commits intoelementary-swift:mainfrom Feb 18, 2026
Merged
Added ability to set attributes on body in HTMLDocument types#94sliemeobn merged 3 commits intoelementary-swift:mainfrom
HTMLDocument types#94sliemeobn merged 3 commits intoelementary-swift:mainfrom
Conversation
sliemeobn
reviewed
Feb 18, 2026
| // which would cause confusing issues when adopters provide a property of a non-optional type. | ||
| private let defaultUndefinedLanguage = "" | ||
| private let defaultUndefinedDirection = "" | ||
| private let defaultUndefinedAttributes: [HTMLAttribute<HTMLTag.body>] = [] |
Collaborator
There was a problem hiding this comment.
I don't think we need this here (since we never conditionally check for it)
sliemeobn
reviewed
Feb 18, 2026
| /// The default value for the `dir` property is an empty string and will not be rendered in the HTML. | ||
| var dir: HTMLAttributeValue.Direction { .init(value: defaultUndefinedDirection) } | ||
| /// The default value for the `bodyAttribute` property is an empty array. | ||
| var bodyAttributes: [HTMLAttribute<HTMLTag.body>] { defaultUndefinedAttributes } |
Collaborator
There was a problem hiding this comment.
I think it would be cleaner to "just" return an empty array here
sliemeobn
reviewed
Feb 18, 2026
Collaborator
sliemeobn
left a comment
sliemeobn
left a comment
There was a problem hiding this comment.
overall lgtm, thanks!
I would prefer to not use the "empty value constant" for now reason
sliemeobn
changed the title
sliemeobn
changed the title
HTMLDocument types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added ability to set attributes on the body tag.
Added tests.