Skip to content

Styles: add drag-accept style to icon groups - #570

Merged
danirabbit merged 5 commits into
mainfrom
danirabbit/css-dragaccept
Jan 30, 2026
Merged

Styles: add drag-accept style to icon groups#570
danirabbit merged 5 commits into
mainfrom
danirabbit/css-dragaccept

Conversation

@danirabbit

Copy link
Copy Markdown
Member

Fixes #532

Drag a running app to a workspace for example

@danirabbit
danirabbit requested a review from a team January 23, 2026 17:03
@danirabbit danirabbit moved this to Needs review in OS 8.1.1 Jan 23, 2026
@wpkelso

wpkelso commented Jan 23, 2026

Copy link
Copy Markdown
Member

@danirabbit I'm not seeing anything different

Kooha-2026-01-23-15-29-00.webm

@danirabbit

Copy link
Copy Markdown
Member Author

Yeah for whatever reason it looks like it's not giving the drag event in Gala, gonna move to draft

Kooha-2026-01-23-12-35-24.mp4

@danirabbit danirabbit added this to OS 9 Jan 23, 2026
@danirabbit danirabbit removed this from OS 8.1.1 Jan 23, 2026
@danirabbit danirabbit moved this to Needs Discussion in OS 9 Jan 23, 2026
@danirabbit
danirabbit marked this pull request as draft January 23, 2026 20:37
@leolost2605

Copy link
Copy Markdown
Member

Yes dragging from gala to the dock isn't "real" drag and drop via the protocol but instead via dbus which is handled in the windowdragmanager. I think setting state flags of the current_icon_group in windowdragmanager to drop active everywhere we call window_entered and unsetting it when we call window_left could work.

@danirabbit
danirabbit marked this pull request as ready for review January 25, 2026 21:01
@danirabbit
danirabbit requested a review from a team January 25, 2026 21:01
@danirabbit danirabbit removed this from OS 9 Jan 27, 2026
@danirabbit danirabbit moved this to Needs review in OS 8.1.1 Jan 27, 2026
@flodavid

flodavid commented Jan 27, 2026

Copy link
Copy Markdown
Contributor

I tested this and it appears that icons are blurry when a workspace is hovered. I guess what is happening is that the icons are downscaled for them to fit in the workspace square, but then they are slightly upscaled from the lower resolution when the workspace square is enlarged.
This is not a major issue, but it would be nice if it could be improved.

Example with the cogs where details are all blurred out. 1080p monitor with normal scaling. Dock size increased for the example, but also visible with normal size:
Screenshot from 2026-01-27 20 26 18

@danirabbit

danirabbit commented Jan 27, 2026

Copy link
Copy Markdown
Member Author

The only way to keep perfectly sharp icons would be not to scale them at all, which I suppose we could do but we'd have to rewrite the icon grid to not be a child of the container we're styling with the scale effect. But that would also effect button presses, so it would be fairly complicated

@danirabbit

Copy link
Copy Markdown
Member Author

@leolost2605 can I get a re-review? I'd love to get this into the next release :)

@danirabbit
danirabbit merged commit 2257e85 into main Jan 30, 2026
4 checks passed
@danirabbit
danirabbit deleted the danirabbit/css-dragaccept branch January 30, 2026 17:14
@github-project-automation github-project-automation Bot moved this from Needs review to Done in OS 8.1.1 Jan 30, 2026
@danirabbit

Copy link
Copy Markdown
Member Author

@flodavid can you open a separate issue report about this? It's worth investigating in a follow up branch I think

@flodavid

flodavid commented Feb 7, 2026

Copy link
Copy Markdown
Contributor

@danirabbit I created #574

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Expand workspace to accept drops

4 participants