Make dock scrollable instead of extending off screen - #598
Conversation
leolost2605
left a comment
There was a problem hiding this comment.
This is really cool :)
The code LGTM :)
I think for now this makes sense to fix the issue and we can fine tune always later (maybe add an overflow menu instead of scrolling?) but I'll leave a ux review to @elementary/ux
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
This is cool! makes me wish we had a nice masked underscroll effect. ✅ I like the scrollbar being below the dock. Very cool. Looks good. Might need some custom CSS for the trough but no big deal
|
|
@danirabbit Done! |
|
With a single workspace, Gtk.ScrolledWindow reserves space for a scrollbar. We probably can put the scrolled into revealer and only reveal scrolled when there are workspaces. But this definitely needs some a bit more work |
Fixes #485