Support running as greeter#2832
Draft
leolost2605 wants to merge 7 commits intomainfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With some minimal changes we can support running gala as the compositor for the greeter and given the many things gala has to do these days I think this is probably the way to go (e.g. also on screen keyboard, input methods, etc.)
To keep a nice overview of things that are different between the different session types I decided to introduce a
SessionSettingsnamespace that actually has meaningful options likeshould_blur_background,should_fade_in, etc instead of having the appropriate places just query the session type and then decide what to do. IMO it's good to keep this overview instead of having to go hunt through all files and also it's easy to adjust how we get the session type etc., but I'd like to hear other opinions. Or if there are other ideas for how to handle these differences between the session types I'd be happy to hear them.This already works with #elementary/greeter#878 but it still needs a bit of polish.