Skip to content

Generate animation assets from SVG - #7

Open
meisenzahl wants to merge 28 commits into
mainfrom
generate-animation-assets-from-svg
Open

Generate animation assets from SVG#7
meisenzahl wants to merge 28 commits into
mainfrom
generate-animation-assets-from-svg

Conversation

@meisenzahl

Copy link
Copy Markdown
Member

Closes #6

@meisenzahl

Copy link
Copy Markdown
Member Author

This now overlaps somewhat with #5 😅

@meisenzahl
meisenzahl marked this pull request as ready for review November 19, 2020 18:32
@cassidyjames

Copy link
Copy Markdown
Contributor

@meisenzahl ah I forgot to mention that I also had to recolor it to white. 😅

@cassidyjames
cassidyjames requested a review from a team November 21, 2020 07:12
Comment thread meson/postconf.py Outdated
Co-authored-by: Julian Raschke <julian@raschke.de>
@meisenzahl meisenzahl mentioned this pull request Dec 5, 2020
@cassidyjames
cassidyjames requested a review from a team December 6, 2020 20:31
Comment thread debian/rules Outdated
Comment thread meson.build Outdated
@meisenzahl
meisenzahl requested a review from tintou December 7, 2020 18:09

@cassidyjames cassidyjames left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add imagemagick to the meson dependencies here since this fails without it installed.

Comment thread debian/rules Outdated
@danirabbit

Copy link
Copy Markdown
Member

I can't confirm that this works. I get:

[0/1] Installing files.
Running custom install script '/home/daniel/Projects/plymouth-theme/meson/post_install.py'
convert-im6.q16: unable to open image `/usr/share/plymouth/themes/elementary/throbber-0000.png': No such file or directory @ error/blob.c/OpenBlob/2874.
convert-im6.q16: WriteBlob Failed `/usr/share/plymouth/themes/elementary/throbber-0000.png' @ error/png.c/MagickPNGErrorHandler/1641.
convert-im6.q16: unable to open image `/usr/share/plymouth/themes/elementary/throbber-0000.png': No such file or directory @ error/blob.c/OpenBlob/2874.
convert-im6.q16: no images defined `/usr/share/plymouth/themes/elementary/throbber-0000.png' @ error/convert.c/ConvertImageCommand/3258.
convert-im6.q16: unable to open image `/usr/share/plymouth/themes/elementary/throbber-0000.png': No such file or directory @ error/blob.c/OpenBlob/2874.
convert-im6.q16: no images defined `/usr/share/plymouth/themes/elementary/throbber-0000.png' @ error/convert.c/ConvertImageCommand/3258.
Traceback (most recent call last):
  File "/home/daniel/Projects/plymouth-theme/meson/post_install.py", line 52, in <module>
    shutil.copyfile(
  File "/usr/lib/python3.8/shutil.py", line 261, in copyfile
    with open(src, 'rb') as fsrc, open(dst, 'wb') as fdst:
FileNotFoundError: [Errno 2] No such file or directory: '/usr/share/plymouth/themes/elementary/throbber-0000.png'
FAILED: meson-install 
/usr/bin/meson install --no-rebuild
ninja: build stopped: subcommand failed.

@meisenzahl

Copy link
Copy Markdown
Member Author

@danrabbit thanks for testing this. The last commit should fix it. Running debuild works and now only fails because of missing keys to sign the build:

...
dpkg-deb: building package 'plymouth-theme-elementary' in '../plymouth-theme-elementary_5.9.0_all.deb'.
 dpkg-genbuildinfo
 dpkg-genchanges  >../plymouth-theme-elementary_5.9.0_amd64.changes
dpkg-genchanges: info: including full source code in upload
 dpkg-source --after-build .
dpkg-buildpackage: info: full upload; Debian-native package (full source is included)
Now running lintian plymouth-theme-elementary_5.9.0_amd64.changes ...
E: plymouth-theme-elementary: no-copyright-file
W: plymouth-theme-elementary source: no-debian-copyright-in-source
W: plymouth-theme-elementary source: package-uses-deprecated-debhelper-compat-version 7
Finished running lintian.
Now signing changes and any dsc files...
 signfile dsc plymouth-theme-elementary_5.9.0.dsc elementary, Inc. <builds@elementary.io>
gpg: skipped "elementary, Inc. <builds@elementary.io>": No secret key
gpg: /tmp/debsign.J52UkWY8/plymouth-theme-elementary_5.9.0.dsc: clear-sign failed: No secret key
debsign: gpg error occurred!  Aborting....
debuild: fatal error at line 1112:
running debsign failed

@danirabbit danirabbit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay spent some time trying to fix this up but there's some issues still:

  • It current generates 4 frames per step. This is backwards. We want to repeat the whole animation 4 times to make it go faster, not each frame 4 times which makes it slower. So we should generate symlinks 13-36 as we did before
  • The rotated images are kinda blurry. I guess from the resize step? But for some reason we do get some files exported at a larger size without it. So probably need to figure out what the issue is about
  • Do we even need a python script here at all? Is there a reason we can't do this in meson?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generate animation assets from SVG

6 participants