Generate animation assets from SVG - #7
Open
meisenzahl wants to merge 28 commits into
Open
Conversation
Member
Author
|
This now overlaps somewhat with #5 😅 |
meisenzahl
marked this pull request as ready for review
November 19, 2020 18:32
Contributor
|
@meisenzahl ah I forgot to mention that I also had to recolor it to white. 😅 |
jlnr
reviewed
Nov 21, 2020
Co-authored-by: Julian Raschke <julian@raschke.de>
Merged
tintou
reviewed
Dec 7, 2020
tintou
reviewed
Dec 7, 2020
cassidyjames
suggested changes
Dec 14, 2020
cassidyjames
left a comment
Contributor
There was a problem hiding this comment.
We should add imagemagick to the meson dependencies here since this fails without it installed.
tintou
reviewed
Dec 15, 2020
Member
|
I can't confirm that this works. I get: |
…ntary/plymouth-theme into generate-animation-assets-from-svg
Member
Author
|
@danrabbit thanks for testing this. The last commit should fix it. Running |
danirabbit
requested changes
Apr 21, 2025
danirabbit
left a comment
Member
There was a problem hiding this comment.
Okay spent some time trying to fix this up but there's some issues still:
- It current generates 4 frames per step. This is backwards. We want to repeat the whole animation 4 times to make it go faster, not each frame 4 times which makes it slower. So we should generate symlinks 13-36 as we did before
- The rotated images are kinda blurry. I guess from the resize step? But for some reason we do get some files exported at a larger size without it. So probably need to figure out what the issue is about
- Do we even need a python script here at all? Is there a reason we can't do this in meson?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6