Skip to content

refactor: forwardRef is deprecated in React 19 #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alamenai wants to merge 1 commit into
base: main
Choose a base branch
from
+23 −28
Open

refactor: forwardRef is deprecated in React 19 #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 23 additions & 28 deletions apps/www/registry/elevenlabs-ui/ui/voice-button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,11 @@ export type VoiceButtonState =
| "error"

export interface VoiceButtonProps
extends Omit<React.ButtonHTMLAttributes<HTMLButtonElement>, "onError"> {
extends Omit<React.ButtonHTMLAttributes<HTMLButtonElement>, "onError" | "ref"> {
/**
* Ref to the button element
*/
ref?: React.Ref<HTMLButtonElement>
/**
* Current state of the voice button
* @default "idle"
Expand Down Expand Up @@ -85,28 +89,22 @@ export interface VoiceButtonProps
disabled?: boolean
}

export const VoiceButton = React.forwardRef<
HTMLButtonElement,
VoiceButtonProps
>(
(
{
state = "idle",
onPress,
label,
trailing,
icon,
variant = "outline",
size = "default",
className,
waveformClassName,
feedbackDuration = 1500,
disabled,
onClick,
...props
},
ref
) => {
export const VoiceButton = ({
state = "idle",
onPress,
label,
trailing,
icon,
variant = "outline",
size = "default",
className,
waveformClassName,
feedbackDuration = 1500,
disabled,
onClick,
ref,
...props
}: VoiceButtonProps) => {
const [showFeedback, setShowFeedback] = React.useState(false)

React.useEffect(() => {
Expand Down Expand Up @@ -232,8 +230,5 @@ export const VoiceButton = React.forwardRef<
)}
</div>
</Button>
)
}
)

VoiceButton.displayName = "VoiceButton"
)
}