Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts the HTTP responses for the /reload, /restart, and /shutdown API endpoints to avoid returning a JSON-parsable boolean-like body ("true") that can be misinterpreted by clients.
Changes:
- Change successful responses for reload/restart/shutdown from
ctx.String(200, "true")toctx.String(200, ""). - Align these endpoints’ “success” responses with the existing convention in the
apipackage of returning an empty 200 body for action endpoints.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
alternatively we can use
ctx.JSON(200, xbmc.NewView("", xbmc.ListItems{}))so then in curl answer you will see some text.but using
""is consistent with other handlers.fixes
TypeError: 'bool' object is not subscriptablesee elgatito/plugin.video.elementum#1170 (comment)