This repository was archived by the owner on Jun 6, 2021. It is now read-only.
Conversation
based on discussion from here: elidickinson@c00f622#commitcomment-1887500
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on discussion from here:
c00f622#commitcomment-1887500
it seemed strtotime() does not support microseconds, so i left that out
also your file encoding was MSDOS based, and weird file execute bits on files. you might want to fixup that. did not want to do it in my commit, as that would make whole diff unreadable
also for the sake of testing, i made one method protected instead of private, and i noticed some other methods access is not defined at all (indeed that defaults to "public") would be nice to clean those up as well.
so included phpunit test for the date thing only