Skip to content

feat: include producer metadata in per-message events #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josevalim merged 1 commit into from
Apr 7, 2026
Merged

feat: include producer metadata in per-message events #370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions lib/broadway.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -714,7 +714,8 @@ defmodule Broadway do
name: atom,
index: non_neg_integer,
message: Broadway.Message.t,
telemetry_span_context: reference
telemetry_span_context: reference,
producer: {atom, list}
}
```

Expand All @@ -732,7 +733,8 @@ defmodule Broadway do
name: atom,
index: non_neg_integer,
message: Broadway.Message.t,
telemetry_span_context: reference
telemetry_span_context: reference,
producer: {atom, list}
}
```

Expand All @@ -753,7 +755,8 @@ defmodule Broadway do
kind: kind,
reason: reason,
stacktrace: stacktrace,
telemetry_span_context: reference
telemetry_span_context: reference,
producer: {atom, list}
}
```

Expand Down
6 changes: 4 additions & 2 deletions lib/broadway/topology/processor_stage.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,8 @@ defmodule Broadway.Topology.ProcessorStage do
index: state.partition,
name: state.name,
message: message,
context: state.context
context: state.context,
producer: state.producer
},
fn ->
updated_message =
Expand All @@ -179,7 +180,8 @@ defmodule Broadway.Topology.ProcessorStage do
index: state.partition,
name: state.name,
message: updated_message,
context: state.context
context: state.context,
producer: state.producer
}}
end
)
Expand Down
6 changes: 3 additions & 3 deletions test/broadway_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -946,10 +946,10 @@ defmodule BroadwayTest do
assert_receive {:telemetry_event, [:broadway, :processor, :start], %{system_time: _}, %{}}

assert_receive {:telemetry_event, [:broadway, :processor, :message, :start],
%{system_time: _}, %{}}
%{system_time: _}, %{producer: {ManualProducer, []}}}

assert_receive {:telemetry_event, [:broadway, :processor, :message, :stop], %{duration: _},
%{}}
%{producer: {ManualProducer, []}}}

assert_receive {:telemetry_event, [:broadway, :processor, :stop], %{duration: _}, metadata}
assert [] = metadata.failed_messages
Expand Down Expand Up @@ -1022,7 +1022,7 @@ defmodule BroadwayTest do
%{system_time: _}, %{}}

assert_receive {:telemetry_event, [:broadway, :processor, :message, :exception],
%{duration: _}, %{}}
%{duration: _}, %{producer: {ManualProducer, []}}}

assert_receive {:telemetry_event, [:broadway, :processor, :stop], %{duration: _}, %{}}
assert_receive {:ack, ^ref, [], [%{status: {:error, _, _}}]}
Expand Down