Merged
Conversation
Contributor
Author
|
So it turns out there was a race condition that only happened in tests, I was able to fix it in this commit: in other words haystack is still good to go! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @philipbrown,
Thank you for creating this package, I have been using it for quite some time and it's been great, however after upgrading to Elixir 1.18.0 I noticed that it had some issues compiling and while it was still working some tests were failing in my app, I have updated the deps and ran the tests and everything seems to be ok, also the tests from my app don't fail anymore after pointing to my fork, let me know if this is ok as is or if you want me to do anything additional in order to get this merged, thanks!
PS.: I think I spoke too soon, I will continue debugging and update this PR when I figure out the underlying issue, there is still 1 tests failing in my app that depends on haystack.
Gabriel.