Track the current collectable accumulator during for ..., into: ... - #15266
Closed
lukaszsamson wants to merge 3 commits into
Closed
Track the current collectable accumulator during for ..., into: ...#15266lukaszsamson wants to merge 3 commits into
lukaszsamson wants to merge 3 commits into
Conversation
Pass the current accumulator to final :halt invocation on exception Fixes elixir-lang#15265
Member
|
@lukaszsamson I believe instead we should wrap the content of the do-block in the try-catch. |
Contributor
Author
|
Is this what you had in mind @josevalim? |
Member
|
I think so but I will have to review carefully tomorrow :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass the current accumulator to final :halt invocation on exception
The PR addresses issue in for ... into: ..., Enum.into and Stream.into
Fixes #15265