Skip to content

Optimize unpercent with guard and by avoiding with clause #15476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josevalim merged 1 commit into from
Jun 14, 2026
Merged

Optimize unpercent with guard and by avoiding with clause #15476

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions lib/elixir/lib/uri.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,18 +484,19 @@ defmodule URI do
unpercent(string, "", true)
end

defguardp is_hex(char) when char in ?0..?9 or char in ?A..?F or char in ?a..?f

defp unpercent(<<?+, tail::binary>>, acc, spaces = true) do
unpercent(tail, <<acc::binary, ?\s>>, spaces)
end

defp unpercent(<<?%, h1, h2, tail::binary>>, acc, spaces)
when is_hex(h1) and is_hex(h2) do
unpercent(tail, <<acc::binary, bsl(hex_to_dec(h1), 4) + hex_to_dec(h2)>>, spaces)
end

defp unpercent(<<?%, tail::binary>>, acc, spaces) do
with <<hex1, hex2, tail::binary>> <- tail,
dec1 when is_integer(dec1) <- hex_to_dec(hex1),
dec2 when is_integer(dec2) <- hex_to_dec(hex2) do
unpercent(tail, <<acc::binary, bsl(dec1, 4) + dec2>>, spaces)
else
_ -> unpercent(tail, <<acc::binary, ?%>>, spaces)
end
unpercent(tail, <<acc::binary, ?%>>, spaces)
end

defp unpercent(<<head, tail::binary>>, acc, spaces) do
Expand All @@ -508,7 +509,6 @@ defmodule URI do
defp hex_to_dec(n) when n in ?A..?F, do: n - ?A + 10
defp hex_to_dec(n) when n in ?a..?f, do: n - ?a + 10
defp hex_to_dec(n) when n in ?0..?9, do: n - ?0
defp hex_to_dec(_n), do: nil

@doc """
Creates a new URI struct by parsing and validating a string or from an existing URI.
Expand Down
Loading