Skip to content

Optimize URI.to_string/1 #15477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josevalim merged 2 commits into from
Jun 14, 2026
Merged

Optimize URI.to_string/1 #15477

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72ef0c6
Optimize URI.to_string/1
preciz Jun 14, 2026
0572ebb
Update lib/elixir/lib/uri.ex
preciz Jun 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 18 additions & 11 deletions lib/elixir/lib/uri.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1090,15 +1090,18 @@ defimpl String.Chars, for: URI do
":path in URI must be empty or an absolute path if URL has a :host, got: #{inspect(uri)}"
end

def to_string(%{scheme: scheme, port: port, path: path, query: query, fragment: fragment} = uri) do
uri =
case scheme && URI.default_port(scheme) do
^port -> %{uri | port: nil}
_ -> uri
end

def to_string(%{
host: host,
authority: authority,
userinfo: userinfo,
scheme: scheme,
port: port,
path: path,
query: query,
fragment: fragment
}) do
# Based on https://tools.ietf.org/html/rfc3986#section-5.3
authority = extract_authority(uri)
authority = extract_authority(host, authority, scheme, userinfo, port)

IO.iodata_to_binary([
if(scheme, do: [scheme, ?:], else: []),
Expand All @@ -1109,19 +1112,23 @@ defimpl String.Chars, for: URI do
])
end

defp extract_authority(%{host: nil, authority: authority}) do
defp extract_authority(_host = nil, authority, _scheme, _userinfo, _port) do
authority
end

defp extract_authority(%{host: host, userinfo: userinfo, port: port}) do
defp extract_authority(host, _authority, scheme, userinfo, port) do
# According to the grammar at
# https://tools.ietf.org/html/rfc3986#appendix-A, a "host" can have a colon
# in it only if it's an IPv6 or "IPvFuture" address, so if there's a colon
# in the host we can safely surround it with [].

[
if(userinfo, do: [userinfo | "@"], else: []),
if(String.contains?(host, ":"), do: ["[", host | "]"], else: host),
if(port, do: [":" | Integer.to_string(port)], else: [])
if(port != nil and (is_nil(scheme) or URI.default_port(scheme) != port),
do: [":" | Integer.to_string(port)],
else: []
)
]
end
end
Loading