Fix missed optimization of Kernel.put_elem/3 - #15480
Merged
Merged
Conversation
?reorder added in 87582af used wrong arity and wrong erlang call
Contributor
|
Nice catch! Maybe we could add a test to |
Member
|
I don't think we need a test honestly because the test would be basically duplicating a line from a macro. :( It would have caught the regression, but only if we duplicate all. A code review would also have caught it (my bad). |
Member
|
💚 💙 💜 💛 ❤️ |
josevalim
pushed a commit
that referenced
this pull request
Jun 15, 2026
?reorder added in 87582af used wrong arity and wrong erlang call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
?reordermacro added in 87582af used wrong arity and wrong erlang call. No impact besides missed optimization