Skip to content

Fix definition of term_or_dynamic_optional type #15498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josevalim merged 2 commits into from
Jun 17, 2026
Merged

Fix definition of term_or_dynamic_optional type #15498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a4837a
Fix definition of term_or_dynamic_optional type
lukaszsamson Jun 16, 2026
ee462ef
Update descr_test.exs
josevalim Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/elixir/lib/module/types/descr.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ defmodule Module.Types.Descr do

@not_set %{optional: 1}
@term_or_optional Map.put(@term, :optional, 1)
@term_or_dynamic_optional Map.put(@term, :dynamic, %{optional: 1})
@term_or_dynamic_optional Map.put(@term, :dynamic, @term_or_optional)
@not_atom_or_optional Map.delete(@term_or_optional, :atom)

@empty_intersection [0, :bdd_bot]
Expand Down
6 changes: 6 additions & 0 deletions lib/elixir/test/elixir/module/types/descr_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1033,6 +1033,12 @@ defmodule Module.Types.DescrTest do
refute subtype?(if_set(term()), term())
assert subtype?(if_set(term()), if_set(term()))
refute subtype?(if_set(term()), if_set(dynamic(term())))

# Test that union+dynamic optimizations preserves properties
t = opt_union(term(), dynamic(not_set()))
assert subtype?(term(), t)
assert subtype?(dynamic(), t)
assert subtype?(dynamic(integer()), t)
end

test "list" do
Expand Down
Loading