Skip to content

Include bitstring in domain keys #15516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josevalim merged 1 commit into from
Jun 23, 2026
Merged

Include bitstring in domain keys #15516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/elixir/lib/module/types/descr.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ defmodule Module.Types.Descr do
defguardp fields_size(fields) when length(fields)

@domain_key_types :lists.sort(
[:binary, :integer, :float, :pid, :port, :reference] ++
[:binary, :bitstring, :integer, :float, :pid, :port, :reference] ++
[:fun, :atom, :tuple, :map, :list]
)

Expand Down
9 changes: 8 additions & 1 deletion lib/elixir/test/elixir/module/types/descr_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1053,6 +1053,13 @@ defmodule Module.Types.DescrTest do

assert subtype?(t2, t1)

# An open map is open in every domain key, including :bitstring.
open_pid = open_map([{domain_key(:pid), pid()}])

for d <- [:bitstring, :binary, :integer, :float, :atom, :tuple, :map, :list] do
assert subtype?(closed_map([{[d], atom([:x])}]), open_pid)
end

t1_minus_t2 = opt_difference(t1, t2)
refute empty?(t1_minus_t2)

Expand Down Expand Up @@ -2258,7 +2265,7 @@ defmodule Module.Types.DescrTest do

assert list(
Enum.reduce(
[binary(), float(), pid(), port(), reference()] ++
[binary(), bitstring_no_binary(), float(), pid(), port(), reference()] ++
[fun(), atom(), tuple(), open_map(), list(term(), term())],
tuple([integer(), binary()]),
fn domain, acc -> opt_union(acc, tuple([domain, term()])) end
Expand Down
Loading