Skip to content

Optimize disjoint function argument checks #15637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josevalim merged 2 commits into from
Jul 19, 2026
Merged

Optimize disjoint function argument checks #15637

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b077c38
Optimize disjoint function argument checks
preciz Jul 19, 2026
9ef9dfa
Apply suggestion from @josevalim
josevalim Jul 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/elixir/lib/module/types/descr.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1871,10 +1871,12 @@ defmodule Module.Types.Descr do
end

# For two arguments to be disjoint, one of their types must be disjoint.
defp disjoint_arguments?(args1, args2) do
Enum.any?(Enum.zip(args1, args2), fn {t1, t2} -> disjoint?(t1, t2) end)
defp disjoint_arguments?([type1 | args1], [type2 | args2]) do
disjoint?(type1, type2) or disjoint_arguments?(args1, args2)
end

defp disjoint_arguments?([], []), do: false

defp all_disjoint_arguments?([]), do: true

defp all_disjoint_arguments?([bdd_leaf(args, _) | rest]) do
Expand Down
Loading