Fix Registry doc and listener_message type - #15640
Merged
Merged
Conversation
josevalim
reviewed
Jul 20, 2026
| @type listener_message :: | ||
| {:register, registry, key, registry_partition :: pid, value} | ||
| | {:unregister, registry, key, registry_partition :: pid} | ||
| {:register, registry, key, process :: pid, value} |
Member
There was a problem hiding this comment.
That's conveying less information. Before we were saying that's the pid related to the registry partition. Now we just say process :: pid, which is redundant.
Contributor
Author
There was a problem hiding this comment.
registry_partition is invalid label because, according impl here is the PID of process is registering or unregistering not a partition pid.
process name may not be precise enough. Do you have any suggestions for a better label name?
Contributor
Author
There was a problem hiding this comment.
registered_process and unregistered_process?
Member
There was a problem hiding this comment.
Got it! Let’s just remove the label then! Thank you!!
AlexGx
force-pushed
the
ag-registry_spec-doc-fix
branch
from
July 20, 2026 18:31
39724a1 to
3118b95
Compare
Member
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most notable:
listener_message's registry_partition -> process