Skip to content

Remove redundant abs calls from Calendar.ISO #15675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josevalim merged 1 commit into from
Jul 25, 2026
Merged

Remove redundant abs calls from Calendar.ISO #15675

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/elixir/lib/calendar/iso.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1176,7 +1176,7 @@ defmodule Calendar.ISO do
@doc since: "1.8.0"
@spec year_of_era(year) :: {1..10_000, era}
def year_of_era(year) when is_year_CE(year), do: {year, 1}
def year_of_era(year) when is_year_BCE(year), do: {abs(year) + 1, 0}
def year_of_era(year) when is_year_BCE(year), do: {1 - year, 0}

@doc """
Calendar callback to compute the year and era from the
Expand Down Expand Up @@ -1229,7 +1229,7 @@ defmodule Calendar.ISO do
end

def day_of_era(year, month, day) when is_year_BCE(year) do
day = abs(date_to_iso_days(year, month, day) - @iso_epoch)
day = @iso_epoch - date_to_iso_days(year, month, day)
{day, 0}
end

Expand Down
Loading