Skip to content

Remove accumulator from Version.parse_digits. #15722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josevalim merged 1 commit into from
Aug 7, 2026
+6 −6
Merged

Remove accumulator from Version.parse_digits. #15722

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions lib/elixir/lib/version.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,17 +633,17 @@ defmodule Version do
defp require_digits(string) do
if leading_zero?(string) or byte_size(string) > @max_numeric_component_digits,
do: :error,
else: parse_digits(string, "")
else: parse_digits(string)
end

defp leading_zero?(<<?0, _, _::binary>>), do: true
defp leading_zero?(_), do: false

defp parse_digits(<<char, rest::binary>>, acc) when char in ?0..?9,
do: parse_digits(rest, <<acc::binary, char>>)
defp parse_digits(<<>>), do: :error

defp parse_digits(<<>>, acc) when byte_size(acc) > 0, do: {:ok, String.to_integer(acc)}
defp parse_digits(_, _acc), do: :error
defp parse_digits(string) do
if all_digits?(string), do: {:ok, :erlang.binary_to_integer(string)}, else: :error
end

defp maybe_patch(patch, approximate?)
defp maybe_patch(nil, true), do: {:ok, nil}
Expand All @@ -667,7 +667,7 @@ defmodule Version do
end

defp convert_parts_to_integer([part | rest], acc) do
case parse_digits(part, "") do
case parse_digits(part) do
{:ok, integer} ->
if leading_zero?(part) do
:error
Expand Down
Loading