Optimize URI.append_query field access - #15741
Merged
Merged
Conversation
Bind the current query in the function head so generated code can reuse the field instead of emitting repeated dynamic access paths. Assisted-by: Codex:GPT-5
Contributor
|
looks like |
Contributor
Author
Did you mean |
Contributor
yes, sorry for typo |
Contributor
Author
ok, I wanted to keep this PR simple, since that would only save 2 instructions, but there was another marginal save, if in previous function head we pattern match |
Member
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assisted-by: Codex CLI:GPT-5.6 Sol
Bind the current query in the function head so generated code can reuse the field instead of emitting repeated dynamic access paths.