Fix content container scrolling in older versions of Safari#2208
Draft
DavidOliver wants to merge 1 commit intoelixir-lang:mainfrom
Draft
Fix content container scrolling in older versions of Safari#2208DavidOliver wants to merge 1 commit intoelixir-lang:mainfrom
DavidOliver wants to merge 1 commit intoelixir-lang:mainfrom
Conversation
It seems the 'content' CSS container being placed on the absolutely-positioned, 100% height 'main' element results in a lack of vertical scrolling in Safari 17.6. The container was placed on the 'main' element to allow setting of --hX-size custom properties of the .content-inner element based on a size query using said element. Here, we move the container back to .content-inner and directly use the font size values themselves in the relevant rules. Also removes outdated comment related to headings. Fixes elixir-lang#2207
|
📦 Docs artifacts are ready: https://github.com/elixir-lang/ex_doc/actions/runs/22553523927/artifacts/5712725357 |
josevalim
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems the 'content' CSS container being placed on the absolutely-positioned, 100% height 'main' element results in a lack of vertical scrolling in Safari 17.6. The container was placed on the 'main' element to allow setting of --hX-size custom properties of the .content-inner element based on a size query using said element. Here, we move the container back to .content-inner and directly use the font size values themselves in the relevant rules.
Also removes outdated comment related to headings.
Fixes #2207