fix double filename calls while put'ing

[petermueller]

DO NOT MERGE TO main

Due to scope of change (and based on prior discussion) we may prefer to just roll this into a 0.3 version release.

TODO

• update test setup for failing tests
• clean up organization of tests
• extend usage of unique_basename / tmp_dir tag to the rest of the CloudStorage tests

[petermueller]

@achempion
Since a lot of these tests are modifications/tweaks of the S3 tests, I'm thinking it makes sense to have this be part of a first pass at pulling GCP into the upstream.

My only concern is that the dependencies of gcp go back to Google 's maintained library that is half abandoned and still using a very outdated version of Poison and some other libraries.

When we pull it in I think it may be beneficial to have waffle be a monorepo for the ease of testing all the adapters but still separate mix files until we can move away from that library or figure something else out

What are your thoughts?

[achempion]

My only concern is that the dependencies of gcp go back to Google 's maintained library that is half abandoned and still using a very outdated version of Poison and some other libraries.

It shouldn't be an issue with monorepo, as including them will be a part of adapter specific documentation similar to how it works in Swoosh

Since a lot of these tests are modifications/tweaks of the S3 tests, I'm thinking it makes sense to have this be part of a first pass at pulling GCP into the upstream.

agree 👍