Conversation
|
@ulissesalmeida I was thinking we'd merge #6, then I'd update this as does that sound okay to you? |
|
I think the jose update and elixir v1.12 should be included in the 0.3. (I wouldn't mind everything being released as 0.3, so I'm with you whatever the path you choose) |
54c92cf to
65d6589
Compare
CHANGELOG.md
Outdated
|
|
||
| ### Removed | ||
|
|
||
| - **Breaking:** drop maintenance support for Elixir versions `< v1.12` |
There was a problem hiding this comment.
If this has happened, should the mix.exs be updated to reflect the changed version requirement?
There was a problem hiding this comment.
That's actually why I haven't merged this. I think I originally added this thinking it would go with the jose update, but I may just remove this?
I need to run it to confirm 1.9 would still work though.
|
Hmm, the @ulissesalmeida or @fastjames, could one of you by chance try and compile and run the tests against 1.9 for this branch, or main? |
|
I was able to confirm it passes on 1.9, but you have to remove It's been at 0.25 for nearly 2 years, which requires 1.10 anyway. What do you think as far as support? I tend to fall in the camp of "follow what is considered supported by the core team", which goes back to 1.12 https://hexdocs.pm/elixir/1.16.2/compatibility-and-deprecations.html |
I am of the same opinion -- I think specifying 1.12 and up is the way to go. |
|
Ok. Between the 1.12, the deprecation of the I'll take a look this week at merging the rest of the stuff, updating the changelog and |
b3f012f to
2c1f749
Compare
CHANGELOG.md(fixes make a CHANGELOG.md #8)