Skip to content

recv_buffer is never nil

76490f0
Select commit
Loading
Failed to load commit list.
Merged

TCP ICE first iteration #89

recv_buffer is never nil
76490f0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 19, 2026 in 1s

87.13% (+1.06%) compared to 34824b2

View this Pull Request on Codecov

87.13% (+1.06%) compared to 34824b2

Details

Codecov Report

❌ Patch coverage is 90.74890% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.13%. Comparing base (34824b2) to head (76490f0).

Files with missing lines Patch % Lines
lib/ex_ice/priv/transport/tcp_client.ex 85.71% 11 Missing ⚠️
lib/ex_ice/candidate.ex 82.14% 5 Missing ⚠️
lib/ex_ice/priv/app.ex 50.00% 1 Missing ⚠️
lib/ex_ice/priv/candidate.ex 96.87% 1 Missing ⚠️
lib/ex_ice/priv/ice_agent.ex 97.61% 1 Missing ⚠️
lib/ex_ice/priv/mdns/resolver.ex 75.00% 1 Missing ⚠️
lib/ex_ice/priv/transport/tcp.ex 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
+ Coverage   86.06%   87.13%   +1.06%     
==========================================
  Files          25       27       +2     
  Lines        1902     2075     +173     
==========================================
+ Hits         1637     1808     +171     
- Misses        265      267       +2     
Files with missing lines Coverage Δ
lib/ex_ice/ice_agent.ex 70.51% <100.00%> (+4.29%) ⬆️
lib/ex_ice/priv/candidate/host.ex 100.00% <100.00%> (ø)
lib/ex_ice/priv/candidate/prflx.ex 75.00% <100.00%> (+17.85%) ⬆️
lib/ex_ice/priv/candidate/relay.ex 83.67% <100.00%> (+0.34%) ⬆️
lib/ex_ice/priv/candidate/srflx.ex 75.00% <100.00%> (+3.57%) ⬆️
lib/ex_ice/priv/candidate_base.ex 94.11% <100.00%> (+1.26%) ⬆️
lib/ex_ice/priv/checklist.ex 100.00% <ø> (ø)
lib/ex_ice/priv/gatherer.ex 96.00% <100.00%> (+0.22%) ⬆️
lib/ex_ice/priv/transport/udp.ex 100.00% <100.00%> (ø)
test/support/transport/mock.ex 80.64% <100.00%> (+0.64%) ⬆️
... and 7 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34824b2...76490f0. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.