Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
goal: working distance buttons regardless of car-specific inconsistencies
VW's distance buttons generally have three possible values.
the actual behavior varies. I know that some PQ cars send a value of 1 when distance is pressed depending on equipment. Many cars will send a value of 3, but never use 1 or 2 even when manually adjusting distance. Presumably these inconsistencies could surface across the entire VW lineup.
Since openpilot doesn't really care about distance +1 vs -1 vs toggle, I find the cleanest fix here is to simply check the truthiness of the signal, rather than a specific value.