lazy nonce locks#162
Open
mihaimarcu2004 wants to merge 4 commits into
Open
Conversation
- SignerClient construction no longer performs network I/O; nonces are fetched lazily on first use per api key (async path uses the generated TransactionApi instead of blocking requests) - process_api_key_and_nonce holds a per-api-key asyncio.Lock across nonce assignment and send, so concurrent orders on one key arrive in nonce order while different keys send in parallel - explicit nonce/api_key_index callers bypass the nonce manager entirely - remove unused get_api_key_nonce - add unit tests covering lazy fetch, rotation, ordering under asyncio.gather, per-key parallelism, failure/invalid-nonce recovery Co-Authored-By: mihai <mihai2004marcu@gmail.com>
- extract arg binding into extract_tx_args - name the explicit-nonce and rejected-tx conditions - module-level DEFAULT_NONCE / DEFAULT_API_KEY_INDEX constants - docstring describing the locking/ordering behavior Co-Authored-By: mihai <mihai2004marcu@gmail.com>
This reverts commit 54093f6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.