Ensure all swapchains have a unique handle#2
Open
fholger wants to merge 1 commit intoelliotttate:masterfrom
Open
Ensure all swapchains have a unique handle#2fholger wants to merge 1 commit intoelliotttate:masterfrom
fholger wants to merge 1 commit intoelliotttate:masterfrom
Conversation
…ld lead to a new swapchain getting assigned an existing handle, screwing up further swapchain operations
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous approach is incorrect when multiple swapchains are created, destroyed, then recreated - it can lead to a new swapchain being assigned an existing handle, then overwriting that existing swapchain's data and thus corrupting further operations with the swapchains.
Summary by cubic
Guarantees unique swapchain handles to prevent overwriting entries after create/destroy/recreate cycles. This removes handle reuse and stops swapchain data corruption.
(g_swapchains.size() + 2)with a monotonic counterg_nextSwapchainHandle++(initialized at1) forchain.handleassignment.Written for commit 53cbf07. Summary will update on new commits.